Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example] Add Reason example #15340

Merged

Conversation

Tevinthuku
Copy link
Contributor

What does this PR do?

It adds a new example that integrates reason-react, material-ui and create-react app

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 13, 2019

No bundle size changes comparing 1e86a1c...e9df492

Generated by 🚫 dangerJS against e9df492

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 13, 2019

@Tevinthuku Thank you for the pull request :). The growth of Reason is limited: https://www.rank2traffic.com/reasonml.github.io. I'm not sure we want to host the source here.
What do you think of hosting a repository on your side? We can link it.

@Tevinthuku
Copy link
Contributor Author

That would be great, I'll do that 👍

- Edit README to point to example repo
@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Apr 13, 2019
@Tevinthuku Tevinthuku force-pushed the feature/create-reason-react-mui-demo branch from 28ba268 to afd0097 Compare April 13, 2019 19:34
@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Apr 14, 2019
@oliviertassinari oliviertassinari changed the title Create reason-react demo with material-ui [example] Add reason-react Apr 14, 2019
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Apr 14, 2019
@oliviertassinari oliviertassinari changed the title [example] Add reason-react [example] Add Reason example Apr 14, 2019
@oliviertassinari oliviertassinari merged commit 8fd19b8 into mui:next Apr 14, 2019
@oliviertassinari
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants