[docs] Migrate docs' breadcrumbs page to hooks #15349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
approved these changes
Apr 14, 2019
oliviertassinari
added
docs
|
No bundle size changes comparing 5236588...fe42f80 |
|
@kenzhemir Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the doc's breadcrumbs page to hooks. Relates to #15032.
This is not ready for merge yet, since I have encountered some difficulties with typescript definitions in CustomizedBreadcrumbs (lines 12 and 44) and RouterBreadcrumbs (lines 29 and 82). I didn't get what should be the type of Props, when it does not extend WithStyles