[docs] Improve the customization demos #15368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -152,4 +152,4 @@ HiddenCss.propTypes = { | |||
| xsUp: PropTypes.bool, | |||
| }; | |||
|
|
|||
| export default withStyles(styles, { name: 'MuiPrivateHiddenCss' })(HiddenCss); | |||
| export default withStyles(styles, { name: 'PrivateHiddenCss' })(HiddenCss); | |||
There was a problem hiding this comment.
Move Private right to the beginning of the sheet name, it's easier to spot.
| opacity: 0, | ||
| }, | ||
| }, | ||
| expanded: {}, |
There was a problem hiding this comment.
Follow the pseudo class convention. This state is dynamic and overrides previously defined style properties. It should have a specificity of 2.
Details of bundle changes.Comparing: 4e4a2ed...0e73597
|
|
I'm refactoring the ts demos to remove the usage of any. |
oliviertassinari
force-pushed
the
improve-customization-demos
branch
2 times, most recently
from
d681097 to
a8f258e
Compare
oliviertassinari
force-pushed
the
improve-customization-demos
branch
from
a8f258e to
ad738d7
Compare
eps1lon
reviewed
Apr 16, 2019
eps1lon
force-pushed
the
improve-customization-demos
branch
from
48a727a to
e94ac89
Compare
eps1lon
approved these changes
Apr 16, 2019
jztang
pushed a commit
to nyu-ossd-s19/material-ui
that referenced
this pull request
Apr 21, 2019
* [docs] Improve the customization demos * remove typescript usage of any * Cast to a specific type instead of any * fix argos
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are extracted from #15140. It isolates each customization example. Each customization demo is a component on its own. I'm using
withStylesmost of the time as it minimizes boilerplate.