Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add missing styles tests #15376

Merged
merged 1 commit into from
Apr 17, 2019
Merged

[test] Add missing styles tests #15376

merged 1 commit into from
Apr 17, 2019

Conversation

ellisio
Copy link
Contributor

@ellisio ellisio commented Apr 16, 2019

During #15044, the tests for material-ui-styles/src/createGenerateClassName/* were blown away with the same content of their respective implementations.

This brings back the tests for both index counter and hashing.

@mui-pr-bot
Copy link

No bundle size changes comparing 82302c3...caa0b34

Generated by 🚫 dangerJS against caa0b34

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@oliviertassinari
Copy link
Member

@ellisio Nice! It's something I was introducing back in #15140. I'm happy that you picked it up in a different pull request :).

@oliviertassinari oliviertassinari merged commit a231a4c into mui:next Apr 17, 2019
@oliviertassinari
Copy link
Member

I'm merging so I can rebase.

@ellisio ellisio deleted the test/styles/fix-test branch April 17, 2019 14:19
jztang pushed a commit to nyu-ossd-s19/material-ui that referenced this pull request Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants