Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Use tsx syntax highlighting #15385

Merged
merged 1 commit into from
Apr 17, 2019
Merged

[docs] Use tsx syntax highlighting #15385

merged 1 commit into from
Apr 17, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 17, 2019

We use jsx highlighting for all our JS code so we should use tsx highlighting for all our TS code.

@eps1lon eps1lon added docs Improvements or additions to the documentation new feature New feature or request typescript labels Apr 17, 2019
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 13ac4ce...f0b3a03

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 315,642 315,642 85,365 85,365
@material-ui/core/Paper 0.00% 0.00% 67,277 67,277 19,975 19,975
@material-ui/core/Paper.esm 0.00% 0.00% 60,639 60,639 18,883 18,883
@material-ui/core/Popper 0.00% 0.00% 34,906 34,906 11,861 11,861
@material-ui/core/Textarea 0.00% 0.00% 5,866 5,866 2,465 2,465
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,898 15,898 5,773 5,773
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 974 974
@material-ui/lab 0.00% 0.00% 144,207 144,207 43,539 43,539
@material-ui/styles 0.00% 0.00% 50,831 50,831 15,020 15,020
@material-ui/system 0.00% 0.00% 11,765 11,765 3,929 3,929
Button 0.00% 0.00% 88,247 88,247 26,501 26,501
Modal 0.00% 0.00% 82,524 82,524 24,821 24,821
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 50,908 50,908 11,210 11,210
docs.main -0.07% -0.12% 647,091 646,616 201,955 201,710
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 292,276 292,276 82,329 82,329

Generated by 🚫 dangerJS against f0b3a03

oliviertassinari
oliviertassinari approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/PrismJS/prism/blob/master/components/prism-tsx.js

@oliviertassinari oliviertassinari merged commit 395123b into mui:next Apr 17, 2019
jztang pushed a commit to nyu-ossd-s19/material-ui that referenced this pull request Apr 21, 2019
@eps1lon @jztang
[docs] Use tsx syntax highlighting (mui#15385)
159502e
@eps1lon eps1lon deleted the docs/ts-demo-highlight branch May 8, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation new feature New feature or request typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari