-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Link] Improve TypeScript integration with react-router #15412
[Link] Improve TypeScript integration with react-router #15412
Conversation
No bundle size changes comparing 1bff0f7...cb3c1b9 |
Feel free to create a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, an integration test would be great. Ideally, I would add a live demo in https://next.material-ui.com/style/links/#third-party-routing-library. We might already have one demo for the buttons, we can copy.
I have added a live demo for the link, like @eps1lon did for the button. We should be good to go. |
@oliviertassinari - you beat me to it! Just a quick question, when I was looking at other places that react-router-dom is used in the docs such as |
@pachuka Good question. The NoSsr is more a hack than a good solution (Google Bot can still see it with its JavaScript rendering engine). I have solved the problem by using URLs that exist in the documentation. I want to avoid linking 404. |
Closes #15105, closes #15299, based on 3rd suggestion in #15299 (comment)
Since TypographyProps is currently not using OverridableComponent yet, I omitted the 'Component' prop for now to avoid conflicting types.