-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add showcase criteria #15686
[docs] Add showcase criteria #15686
Conversation
cvanem
commented
May 13, 2019
- I have followed (at least) the PR section of the contributing guide.
No bundle size changes comparing 3686a27...99f9453 |
@cvanem Thank you for sharing your project, however, I'm not sure that we should move forward: #15658 (comment). @mbrookes I think that we should write down in the documentation what type of projects we want to showcase, do you agree with these criteria? Basically, I think that it should be a tool for Material-UI to gain credibility, not a tool for the community to create awareness of new projects. |
Do you mean the opposite? If so, then yes, that is the primary motivation. However volume is also a metric that adds to credibility, so, as long as the site meets some reasonable standards for UI / UX, design innovation etc, I don't have an issue adding it. Looking at the screenshot, this does seem to have a nice clean consistent UI, so at first glance is a fair demonstration of Material-UI. My main issue is that the link goes to a login-page, rather than logging in with a demo account, so visitors can't experience it first hand. (While this is also an issue with some of our other showcase sites, they meet some other metric, such as traffic volume.) There is also the question of the subject of this site. While the sale of cannabis is legal in certain jurisdictions, it is not in others, so promoting this site globally could prove problematic (IANAL). Even though it is only a platform, not a vendor's site, it might be viewed as a "risky click" for some visitors. |
This is my main gripe as well. While it might be a full fledged app for users for interested visitors from material-ui.com it's just a signup form. |
The signup form is easily bypassed if you want it set up that way. I'm also fine with not showcasing it if it is controversial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cvanem Thank you for your contributions to Material-UI but we are going to decline your proposal.
I have updated the pull request so we better explain what we are looking for. Also, I have changed the display to show the addition date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM