Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add showcase criteria #15686

Merged
merged 3 commits into from
May 15, 2019
Merged

[docs] Add showcase criteria #15686

merged 3 commits into from
May 15, 2019

Conversation

cvanem
Copy link
Contributor

@cvanem cvanem commented May 13, 2019

@mui-pr-bot
Copy link

mui-pr-bot commented May 13, 2019

No bundle size changes comparing 3686a27...99f9453

Generated by 🚫 dangerJS against 99f9453

@oliviertassinari
Copy link
Member

oliviertassinari commented May 14, 2019

@cvanem Thank you for sharing your project, however, I'm not sure that we should move forward: #15658 (comment).

@mbrookes I think that we should write down in the documentation what type of projects we want to showcase, do you agree with these criteria? Basically, I think that it should be a tool for Material-UI to gain credibility, not a tool for the community to create awareness of new projects.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label May 14, 2019
@mbrookes
Copy link
Member

its a not for Material-UI to gain credibility,

Do you mean the opposite?

If so, then yes, that is the primary motivation. However volume is also a metric that adds to credibility, so, as long as the site meets some reasonable standards for UI / UX, design innovation etc, I don't have an issue adding it.

Looking at the screenshot, this does seem to have a nice clean consistent UI, so at first glance is a fair demonstration of Material-UI. My main issue is that the link goes to a login-page, rather than logging in with a demo account, so visitors can't experience it first hand. (While this is also an issue with some of our other showcase sites, they meet some other metric, such as traffic volume.)

There is also the question of the subject of this site. While the sale of cannabis is legal in certain jurisdictions, it is not in others, so promoting this site globally could prove problematic (IANAL). Even though it is only a platform, not a vendor's site, it might be viewed as a "risky click" for some visitors.

@eps1lon
Copy link
Member

eps1lon commented May 14, 2019

My main issue is that the link goes to a login-page, rather than logging in with a demo account, so visitors can't experience it first hand.

This is my main gripe as well. While it might be a full fledged app for users for interested visitors from material-ui.com it's just a signup form.

@cvanem
Copy link
Contributor Author

cvanem commented May 14, 2019

The signup form is easily bypassed if you want it set up that way. I'm also fine with not showcasing it if it is controversial.

@oliviertassinari oliviertassinari changed the title [docs] Add Greenlink to showcase [docs] Add showcase criteria May 15, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cvanem Thank you for your contributions to Material-UI but we are going to decline your proposal.

I have updated the pull request so we better explain what we are looking for. Also, I have changed the display to show the addition date.

Capture d’écran 2019-05-15 à 08 07 04

@oliviertassinari oliviertassinari requested a review from mbrookes May 15, 2019 12:30
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oliviertassinari oliviertassinari merged commit 67f1f3f into mui:next May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants