[Portal] Fix disablePortal not working #15701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 014a07f...4fc3681
|
eps1lon
reviewed
May 14, 2019
eps1lon
added
bug 🐛
oliviertassinari
approved these changes
May 15, 2019
|
I have added a failing test case, removed the class api, make the test strict mode ready and remove the outdated portal mock. This needed some proper clean up :). |
eps1lon
previously requested changes
May 15, 2019
oliviertassinari
dismissed
eps1lon’s stale review
Thanks, I have removed the disablePortal test suite. I think that it was redundant.
eps1lon
reviewed
May 15, 2019
| @@ -16,8 +16,7 @@ describe('<Popper />', () => { | |||
| }; | |||
|
|
|||
| before(() => { | |||
| // StrictModeViolation: uses Portal | |||
| mount = createMount({ strict: false }); | |||
| mount = createMount({ strict: true }); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the change shown here to fix issue #15612
Closes #15612.