Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Overhaul bundle size guide #15739

Merged
merged 5 commits into from
May 19, 2019
Merged

[docs] Overhaul bundle size guide #15739

merged 5 commits into from
May 19, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 18, 2019

Focus on tree-shaking being default behavior and dev build implications (thanks to @rosskevin) and how to fix possible issues for those.

Removed babel-plugin-lodash since we already document 2 options and the name implies it might stop working any time. Added configuration for the other plugins that were tested in eps1lon/material-ui-tree-shaking-options.

@eps1lon eps1lon added the docs Improvements or additions to the documentation label May 18, 2019

## ECMAScript

The package published on npm is **transpiled**, with [Babel](https://github.com/babel/babel), to take into account the [supported platforms](/getting-started/supported-platforms/).

We also publish a second version of the components to target **evergreen browsers**.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be misunderstood that the /es build targets evergreen browsers. We currently ship syntax in that build that is not supported in all evergreen browsers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eps1lon eps1lon requested a review from mbrookes May 18, 2019 10:46
@mui-pr-bot
Copy link

mui-pr-bot commented May 18, 2019

No bundle size changes comparing 1291dca...3507055

Generated by 🚫 dangerJS against 3507055

@eps1lon eps1lon changed the title [docs] Overhaul bundle size buide [docs] Overhaul bundle size build May 18, 2019
@eps1lon eps1lon changed the title [docs] Overhaul bundle size build [docs] Overhaul bundle size guide May 18, 2019
@eps1lon eps1lon merged commit d6e273f into mui:next May 19, 2019
@eps1lon eps1lon deleted the docs/tree-shaking branch May 19, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants