Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add cross-env to docs:size-why #15816

Merged
merged 1 commit into from
May 24, 2019
Merged

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented May 23, 2019

  • Added cross-env to the docs:size-why command.

Was trying to find the size of the compiled docs website, when yarn docs:size-why failed due to a missing cross-env.
However I was hoping for an output similar to the one from yarn workspace @material-ui/core build, is there a possibility to add that to yarn docs:build as well?

@mui-pr-bot
Copy link

No bundle size changes comparing 35d528c...cf01a9a

Generated by 🚫 dangerJS against cf01a9a

@eps1lon
Copy link
Member

eps1lon commented May 24, 2019

$ DOCS_STATS_ENABLED=true yarn docs:build or $ yarn cross-env DOCS_STATS_ENABLED=true docs:build if your shell doesn't support the first syntax.

$ yarn size:why is probably not that usefull. I recommend using yarn size:snapshot and using ./scripts/sizeSnapshot/build/stats.json for analysis. webpack-analyse, webpack-bundle-analyzer or webpack-visualizer are good tools.

@eps1lon eps1lon changed the title [docs] Add cross-env to docs:size-why [core] Add cross-env to docs:size-why May 24, 2019
@eps1lon eps1lon added the core label May 24, 2019
@eps1lon eps1lon merged commit cb5e664 into mui:master May 24, 2019
@merceyz
Copy link
Member Author

merceyz commented May 24, 2019

$ DOCS_STATS_ENABLED=true yarn docs:build or $ yarn cross-env DOCS_STATS_ENABLED=true docs:build if your shell doesn't support the first syntax.

That's what yarn docs:size-why does, however it keeps failing due to the JS heap running out of memory.

I wanted to check what impact the babel plugin had on a real website, just checking the size of the .next/static folder after running yarn docs:build it's about 56kb smaller.
Using yarn size:snapshot and http://webpack.github.io/analyse it's 2kb

@merceyz merceyz deleted the docs/size-why branch May 24, 2019 15:14
@zannager zannager added the core Infrastructure work going on behind the scenes label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants