Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add dependency react>=16.3.0 requested by @emotion/core and react-jss #15982

Conversation

marco-silva0000
Copy link
Contributor

There is a missing dependency on this worktree, as react is listed as a peer dependency of dependencies @emotion/core and react-jss.

this raises a warning when running with yarn2(berry) and will break PNP when using material-ui as a dependency.

tagging @arcanis as requested in https://yarnpkg.com/en/docs/pnp/troubleshooting

@marco-silva0000 marco-silva0000 changed the title add dependency react>=16.3.0 requested by @emotion/core and react-jss [core] add dependency react>=16.3.0 requested by @emotion/core and react-jss May 31, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented May 31, 2019

No bundle size changes comparing 60071b8...112df5f

Generated by 🚫 dangerJS against 112df5f

@oliviertassinari
Copy link
Member

@marco-silva0000 Would it work with a higher version of React, like the latest version for instance? Also, React is a dependency of the parent package.json. Why do we need to duplicate it?

@marco-silva0000
Copy link
Contributor Author

marco-silva0000 commented May 31, 2019

Would it work with a higher version of React, like the latest version for instance?

It was wrongly pinned, nice catch.

Also, React is a dependency of the parent package.json. Why do we need to duplicate it?

I'm not sure, but I think yarn PNP needs the worktree to list the full dependencies, otherwise it will raise an error when using material-ui in other projects. I have at least a warning when running the new version of yarn with this package.
@arcanis can explain better when available. I may be mistaken.

@oliviertassinari oliviertassinari changed the title [core] add dependency react>=16.3.0 requested by @emotion/core and react-jss [core] Add dependency react>=16.3.0 requested by @emotion/core and react-jss Jun 1, 2019
@oliviertassinari oliviertassinari merged commit 64e0b6d into mui:master Jun 2, 2019
@zannager zannager added the core Infrastructure work going on behind the scenes label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants