[system] Fix typing for flexDirection prop #15987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rhmoller
commented
May 31, 2019
rhmoller
commented
- I have followed (at least) the PR section of the contributing guide.
|
No bundle size changes comparing 4341d90...bfdcb23 |
oliviertassinari
approved these changes
May 31, 2019
|
@oliviertassinari This is another great example of breaking things in strange ways.
|
|
What version of TypeScript are you using? |
|
3.5.3 |
|
Looks like type widening. Try this |
|
Interesting... turning off the Typescript language service in IDEA causes this issue (this is a screenshot of it turned on). The code is already wrapped in make/createStyles.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.