Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theme] Add fontWeightBold to theme.typography #16036

Merged
merged 1 commit into from
Jun 5, 2019
Merged

[theme] Add fontWeightBold to theme.typography #16036

merged 1 commit into from
Jun 5, 2019

Conversation

aditya1906
Copy link
Contributor

@aditya1906 aditya1906 commented Jun 3, 2019 •
edited by oliviertassinari
Loading

Closes #15801

@oliviertassinari

This comment has been minimized.

Sign in to view
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jun 3, 2019
@aditya1906

This comment has been minimized.

Sign in to view
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 3, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 54ce0fa...4d1d9a9

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.02% 🔺 +0.02% 🔺 318,958 319,009 87,399 87,419
@material-ui/core/Paper +0.11% 🔺 +0.11% 🔺 67,892 67,964 20,188 20,210
@material-ui/core/Paper.esm +0.12% 🔺 +0.16% 🔺 61,186 61,258 18,987 19,018
@material-ui/core/Popper 0.00% 0.00% 28,728 28,728 10,344 10,344
@material-ui/core/Textarea 0.00% 0.00% 5,513 5,513 2,373 2,373
@material-ui/core/TrapFocus 0.00% 0.00% 3,755 3,755 1,572 1,572
@material-ui/core/styles/createMuiTheme +0.45% 🔺 +0.47% 🔺 15,944 16,016 5,793 5,820
@material-ui/core/useMediaQuery 0.00% 0.00% 2,529 2,529 1,087 1,087
@material-ui/lab +0.05% 🔺 +0.07% 🔺 138,290 138,362 42,505 42,534
@material-ui/styles 0.00% 0.00% 51,384 51,384 15,186 15,186
@material-ui/system 0.00% 0.00% 14,463 14,463 4,179 4,179
Button +0.09% 🔺 +0.11% 🔺 83,821 83,893 25,471 25,499
Modal 0.00% 0.00% 20,343 20,343 6,687 6,687
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing +0.01% 🔺 +0.02% 🔺 55,038 55,042 13,827 13,830
docs.main 0.00% +0.02% 🔺 653,429 653,435 206,607 206,640
packages/material-ui/build/umd/material-ui.production.min.js +0.02% 🔺 +0.02% 🔺 292,558 292,609 83,364 83,380

Generated by 🚫 dangerJS against 4d1d9a9

@joshwooding

This comment has been minimized.

Sign in to view
@aditya1906

This comment has been minimized.

Sign in to view
@merceyz

This comment has been minimized.

Sign in to view
@joshwooding

This comment has been minimized.

Sign in to view
@merceyz

This comment has been minimized.

Sign in to view
@merceyz

This comment has been minimized.

Sign in to view
@oliviertassinari oliviertassinari mentioned this pull request Jun 4, 2019
Closed
@oliviertassinari oliviertassinari changed the title [docs] Use immediate export in PrimarySearchAppBar [theme] Add fontWeightBold Jun 4, 2019
@oliviertassinari oliviertassinari added new feature New feature or request and removed docs Improvements or additions to the documentation labels Jun 4, 2019
@oliviertassinari oliviertassinari mentioned this pull request Jun 4, 2019
Closed
2 tasks
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 4, 2019 •
edited
Loading

@aditya1906 Could you review the changes I'm proposing? I have tried to keep as many changes as possible that you first introduced.

aditya1906
aditya1906 commented Jun 4, 2019
View reviewed changes
Copy link
Contributor Author

@aditya1906 aditya1906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good enough to introduce fontWeightBold.

@joshwooding joshwooding changed the title [theme] Add fontWeightBold [theme] Add fontWeightBold to theme.typography Jun 5, 2019
@joshwooding joshwooding merged commit 3c3a245 into mui:master Jun 5, 2019
@joshwooding
Copy link
Member

Thanks 👍

@aditya1906 aditya1906 deleted the patch-1 branch June 7, 2019 14:27
@oliviertassinari oliviertassinari mentioned this pull request Jun 7, 2019
Closed
2 tasks
@aditya1906 aditya1906 mentioned this pull request Jun 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@joshwooding joshwooding joshwooding approved these changes

Assignees
No one assigned
Labels
new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CssBaseline] Strong/B tag font weight is being set to 500
5 participants
@aditya1906 @oliviertassinari @mui-pr-bot @joshwooding @merceyz