-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Popper] Add popperRef prop #16069
Merged
oliviertassinari
merged 8 commits into
mui:master
from
oliviertassinari:popper-popperRef
Jun 8, 2019
Merged
[Popper] Add popperRef prop #16069
oliviertassinari
merged 8 commits into
mui:master
from
oliviertassinari:popper-popperRef
Jun 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1aa1961
to
ae902d1
Compare
oliviertassinari
commented
Jun 5, 2019
Details of bundle changes.Comparing: 41f1722...d62b730
|
eps1lon
previously requested changes
Jun 5, 2019
1bf6976
to
0a7e27b
Compare
eps1lon
previously requested changes
Jun 6, 2019
36f40fc
to
59c81f8
Compare
This one was a hard one for me!
eps1lon
reviewed
Jun 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep forgetting I have pending reviews.
Co-Authored-By: Sebastian Silbermann <[email protected]>
Co-Authored-By: Sebastian Silbermann <[email protected]>
62ae024
to
d648da9
Compare
d648da9
to
d62b730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: Popper
The React component. See <Popup> for the latest version.
new feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15802.
These changes are extracted from #15703:
{}
as default prop value. This is a new reference at each render. Most of the time, it's fine. The problem, in this case, is that we are using the value as an effect dependency. It reruns systematically. I have noticed it with a poor slider update performance.popperRef
prop that behaves like a reference. It can be used to programmatically update the position of the popper, e.g. when the slider's thumb value changes.