[docs] Add redirect for typography migration #16077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
docs
eps1lon
commented
Jun 5, 2019
| # link shortener | ||
| /r/styles-instance-warning https://material-ui.com/getting-started/faq#i-have-several-instances-of-styles-on-the-page 307 | ||
| /r/caveat-with-refs-guide https://material-ui.com/guides/composition/#caveat-with-refs 307 | ||
| /r/pseudo-classes-guide https://material-ui.com/guides/composition/#caveat-with-refs 307 |
There was a problem hiding this comment.
https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#3xx_Redirection
Since it might change 301 seems like the wrong choice. It should be switched to 301 if it actually points to a specific version of the docs i.e. the url is no longer used in new code versions.
Details of bundle changes.Comparing: b185d46...0e44f36
|
oliviertassinari
approved these changes
Jun 5, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links in code should be perma links which we control. Once the link becomes outdated we can just switch the redirect which ensures that the links are still valid in older versions of the code.
Closes #16011
/cc @Pajn