Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Pseudo-class: the style rules that require an increase of specificity #16120

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 8, 2019

This changes the description of the style rules that are used as pseudo-classes. Meaning, that they are applied based on the component state and that they are overriding some default style with higher class name specificity (not order).

This new description will signal our users the existence of the difference.

Closes #16051

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jun 8, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 8, 2019

No bundle size changes comparing 07b9d6e...4962241

Generated by 🚫 dangerJS against 4962241

@eps1lon eps1lon added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: good for merge labels Jun 10, 2019
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jun 10, 2019

So, pseudo-classes are class names we don't use to style directly the elements. But instead, they are composed in another selector. The next step could be to document them separately. At least now, the style rules description carry the information. We can rely on it in the generation logic.
cc @joshwooding Were we thinking of the same?

@oliviertassinari oliviertassinari added PR: good for merge and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jun 10, 2019
@oliviertassinari oliviertassinari merged commit 85058cc into mui:master Jun 10, 2019
@oliviertassinari oliviertassinari deleted the docs-pseudo-class branch June 10, 2019 16:30
@joshwooding
Copy link
Member

joshwooding commented Jun 10, 2019

@oliviertassinari Exactly the same, hopefully we can document it well enough that we help users having difficulty with specificity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expansion Panel classes not overriding defaults
4 participants