Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix yarn docs:api removing <br> tags on windows #16165

Merged
merged 1 commit into from
Jun 12, 2019
Merged

[core] Fix yarn docs:api removing <br> tags on windows #16165

merged 1 commit into from
Jun 12, 2019

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jun 11, 2019 •
edited
Loading

  • Properly handle line endings on windows

Extracted from #16146

Closes #15657

@mui-pr-bot
Copy link

No bundle size changes comparing 85058cc...b3e8c8f

Generated by 🚫 dangerJS against b3e8c8f

@oliviertassinari
Copy link
Member

@joshwooding Uses Windows. He will be able to review the changes :)

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work core labels Jun 11, 2019
joshwooding
joshwooding approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@joshwooding joshwooding left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell it doesn't change anything we have currently but it should fix \n\n. It does make the code nicer :)

@merceyz merceyz mentioned this pull request Jun 11, 2019
Merged
1 task
@merceyz merceyz changed the title [core] Fix yarn docs:api on windows [core] Fix yarn docs:api removing <br> on windows Jun 12, 2019
@merceyz merceyz changed the title [core] Fix yarn docs:api removing <br> on windows [core] Fix yarn docs:api removing <br> tags on windows Jun 12, 2019
@eps1lon eps1lon merged commit fbb869a into mui:master Jun 12, 2019
@merceyz merceyz deleted the docs/api branch June 12, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yarn docs:api is removing <br> tags
5 participants
@merceyz @mui-pr-bot @oliviertassinari @joshwooding @eps1lon