-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system] Add support for marginX, marginY, paddingX, and paddingY #16169
Conversation
2e869af
to
41fe4c3
Compare
Details of bundle changes.Comparing: 98292b4...55192bc
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The switch statement you introduce needs a no-op default case. I'm not a fan of aliases though I'm not a fan of the whole API any. @oliviertassinari should make the call here.
41fe4c3
to
c2be9f5
Compare
@eps1lon I agree... if you would like me to make a PR to undo the shorthand syntax (the 2 letter one) I'd be more than happy! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea for consistency with the mx, my, px, py props. I think that we can move forward. We need to update the tests, the documentation. Regarding the implementation, we can probably improve it.
@dimitropoulos I have tried the following 9456f78 (12 insertions(+), 21 deletions(-)) what do you think about it? |
@dimitropoulos It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
I strongly prefer not using the "single letter" shorthand for clarity's sake. That said.. I do really like the
mx
,my
,px
,py
concepts. I tried to change as little as possible to accomplish this. Thoughts?