[styles] Fix react-hot-loader regression #16195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have spent the afternoon/evening trying to migrate to react-jss's
createUseStyles
instead of us having to maintain the logic.However, I'm short on time. It will be more challenging than I first thought. There are a couple of problems to solve, but it will worth it. I have benchmarked a x2 boost when using dynamic style functions.
Instead, I'm going with the "quick-win" approach proposed by @theKashey. Thanks! The logic looks simpler.
Closes #15999
I will continue the react-jss effort migration once this is fixed.