-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slider] Mitigate floating point errors #16252
[Slider] Mitigate floating point errors #16252
Conversation
Details of bundle changes.Comparing: 564aed3...0e3e593
|
@joaosilvalopes Well done. |
This has broken the Slider where the precision of step is small (0.00000001) since it converts to |
Those are the same numbers just represented differently (1e-8 is scientific notation). |
@alitaheri Do you have an idea on how we can solve this problem? |
@oliviertassinari I already have. making a PR. |
🔥 |
When step was a decimal number the calculated value form a value change was coming with floating point errors.
This fixes it by rounding the calculated value to step precision.
Closes #16151