Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Fix various tick mark issues #16275

Merged
merged 6 commits into from
Jun 18, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 18, 2019

  1. Fixes some tick marks being not active if the slider was not configured for the 0-100 range. Closes Slider mark formatting not honouring change to min/max values #16247
  2. Fixes tick marks going out-of-bounds if min is not 0
  3. Some internal polish (remove redundant tests, follow lint rules)

Testing first if 2 is caught by our regression tests.
It is not (because the mark is barely visible?) and therefore cropped from the screenshot.
You can verify it manually though by looking at the deployed demo: The very first discrete slider has a tick mark that has an offset to the left outside of the rail. I recommend a dark theme since it's barely visible in light mode.

@eps1lon eps1lon added bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! labels Jun 18, 2019
@eps1lon eps1lon force-pushed the fix/Slider/marks-issues branch from ff24bd2 to 64f9e62 Compare June 18, 2019 09:41
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 18, 2019

Details of bundle changes.

Comparing: 93f5b33...61a229a

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 319,010 319,010 87,576 87,576
@material-ui/core/Paper 0.00% 0.00% 68,281 68,281 20,353 20,353
@material-ui/core/Paper.esm 0.00% 0.00% 61,578 61,578 19,133 19,133
@material-ui/core/Popper 0.00% 0.00% 28,968 28,968 10,411 10,411
@material-ui/core/Textarea 0.00% 0.00% 5,513 5,513 2,374 2,374
@material-ui/core/TrapFocus 0.00% 0.00% 3,755 3,755 1,580 1,580
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,012 16,012 5,791 5,791
@material-ui/core/useMediaQuery 0.00% 0.00% 2,597 2,597 1,102 1,102
@material-ui/lab +0.02% 🔺 +0.02% 🔺 140,580 140,604 43,454 43,461
@material-ui/styles 0.00% 0.00% 51,703 51,703 15,337 15,337
@material-ui/system 0.00% 0.00% 15,303 15,303 4,342 4,342
Button 0.00% 0.00% 84,279 84,279 25,630 25,630
Modal 0.00% 0.00% 20,345 20,345 6,689 6,689
Slider +0.03% 🔺 +0.02% 🔺 74,681 74,705 23,221 23,226
colorManipulator 0.00% 0.00% 3,904 3,904 1,544 1,544
docs.landing 0.00% 0.00% 55,232 55,232 13,946 13,946
docs.main 0.00% 0.00% 651,051 651,051 205,054 205,054
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 292,254 292,254 83,501 83,501

Generated by 🚫 dangerJS against 61a229a

@eps1lon eps1lon force-pushed the fix/Slider/marks-issues branch 2 times, most recently from 82544bf to cff3412 Compare June 18, 2019 10:08
@eps1lon eps1lon force-pushed the fix/Slider/marks-issues branch from cff3412 to e056930 Compare June 18, 2019 10:23
@eps1lon eps1lon marked this pull request as ready for review June 18, 2019 11:50
@eps1lon eps1lon merged commit a7d25a2 into mui:master Jun 18, 2019
@eps1lon eps1lon deleted the fix/Slider/marks-issues branch June 18, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider mark formatting not honouring change to min/max values
3 participants