Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] Fix node reference #16401

Merged
merged 2 commits into from
Jun 28, 2019
Merged

[Select] Fix node reference #16401

merged 2 commits into from
Jun 28, 2019

Conversation

ffjanhoeck
Copy link
Contributor

@ffjanhoeck ffjanhoeck commented Jun 27, 2019 •
edited by oliviertassinari
Loading

Closes #16270

@ffjanhoeck ffjanhoeck mentioned this pull request Jun 27, 2019
Closed
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 27, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 46af75d...8789cd1

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.01% -0.01% 320,027 320,006 88,354 88,342
@material-ui/core/Paper 0.00% 0.00% 68,290 68,290 20,366 20,366
@material-ui/core/Paper.esm 0.00% 0.00% 61,573 61,573 19,161 19,161
@material-ui/core/Popper 0.00% 0.00% 28,945 28,945 10,395 10,395
@material-ui/core/Textarea 0.00% 0.00% 5,524 5,524 2,378 2,378
@material-ui/core/TrapFocus 0.00% 0.00% 3,753 3,753 1,578 1,578
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,009 16,009 5,791 5,791
@material-ui/core/useMediaQuery 0.00% 0.00% 2,597 2,597 1,102 1,102
@material-ui/lab 0.00% 0.00% 140,075 140,075 43,391 43,391
@material-ui/styles 0.00% 0.00% 51,698 51,698 15,348 15,348
@material-ui/system 0.00% 0.00% 15,420 15,420 4,391 4,391
Button 0.00% 0.00% 84,296 84,296 25,712 25,712
Modal 0.00% 0.00% 14,427 14,427 5,087 5,087
Portal 0.00% 0.00% 3,473 3,473 1,572 1,572
Slider 0.00% 0.00% 74,775 74,775 23,246 23,246
colorManipulator 0.00% 0.00% 3,904 3,904 1,544 1,544
docs.landing 0.00% 0.00% 54,843 54,843 13,901 13,901
docs.main 0.00% 0.00% 647,042 647,042 203,964 203,964
packages/material-ui/build/umd/material-ui.production.min.js -0.00% -0.01% 293,233 293,220 84,239 84,232

Generated by 🚫 dangerJS against 8789cd1

@oliviertassinari oliviertassinari changed the title [Select]: Fix node reference gets undefined if the user change the va… [Select] Fix node reference Jun 27, 2019
@oliviertassinari oliviertassinari added component: select This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Jun 27, 2019
@oliviertassinari oliviertassinari merged commit a663ed8 into mui:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Select] node is undefined
3 participants
@ffjanhoeck @mui-pr-bot @oliviertassinari