[ci] Move TypeScript tests into separate job #16405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 5fb2c56...c53be9a |
oliviertassinari
approved these changes
Jun 28, 2019
There was a problem hiding this comment.
I removed the material-ui-x jon which only had redundant tests.
@eps1lon Yes, you are right, they are redundant tests.
Any specific reason for going down the path of running all the tests vs only running the tests of the packages that changed? Hum, all these tests took 49s to run on this build, splitting them would probably be not a good usage of our time. I guess I have answered my own question.
|
Jest has this built-in and would make sense for PRs i.e. only run changed on PRs but full suite on master. Anything else would require a lot of work. |
|
@oliviertassinari could you update the required checks for the repo? I don't have permissions. |
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of right now
test_staticis the longest running job with typescript using up most of the time. This time will only go up with increasing type coverage.I moved it into a separate job. To not starve the available parallel jobs I removed the
material-ui-xjon which only had redundant tests. With the exception of@material-ui/icons test:built-typingsall tests are already covered bytest:coverage. At least it appears that way from the glob patternpackages/**/*.test.jsbut maybe I'm missing something.@material-ui/icons test:built-typingwas moved intotest_unit.To be mergable someone with repo admin access needs to remove
test_material-ui-xfrom the required checks and replace it withtest_types.Edit: Looks good though test_types is still the slowest. Maybe we need to take a look into composite projects for typescript but this is a good enough start.