Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove ad information icon #16438

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 1, 2019

Follow up on #16380 (comment).

Remove the information icon. It makes it "cleaner". Sebastian was legitimately confused by the display of an i, he is probably not the only one. It can look like a visual bug. My perspective was biased because I originally added it.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 1, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 1, 2019

Details of bundle changes.

Comparing: 7ae741f...7f088bc

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 319,993 319,993 88,291 88,291
@material-ui/core/Paper 0.00% 0.00% 68,292 68,292 20,371 20,371
@material-ui/core/Paper.esm 0.00% 0.00% 61,574 61,574 19,162 19,162
@material-ui/core/Popper 0.00% 0.00% 28,945 28,945 10,401 10,401
@material-ui/core/Textarea 0.00% 0.00% 5,507 5,507 2,362 2,362
@material-ui/core/TrapFocus 0.00% 0.00% 3,753 3,753 1,579 1,579
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,010 16,010 5,790 5,790
@material-ui/core/useMediaQuery 0.00% 0.00% 2,597 2,597 1,103 1,103
@material-ui/lab 0.00% 0.00% 140,286 140,286 43,459 43,459
@material-ui/styles 0.00% 0.00% 51,699 51,699 15,346 15,346
@material-ui/system 0.00% 0.00% 15,420 15,420 4,390 4,390
Button 0.00% 0.00% 84,443 84,443 25,723 25,723
Modal 0.00% 0.00% 14,534 14,534 5,087 5,087
Portal 0.00% 0.00% 3,473 3,473 1,573 1,573
Slider 0.00% 0.00% 75,108 75,108 23,306 23,306
colorManipulator 0.00% 0.00% 3,904 3,904 1,544 1,544
docs.landing 0.00% 0.00% 54,338 54,338 13,762 13,762
docs.main -0.11% -0.11% 647,688 646,952 204,107 203,880
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 292,977 292,977 84,077 84,077

Generated by 🚫 dangerJS against 7f088bc

@oliviertassinari oliviertassinari changed the title [docs] Small ad information icon [docs] Remove ad information icon Jul 2, 2019
@oliviertassinari oliviertassinari force-pushed the docs-ad-small-information branch 2 times, most recently from 0aac20c to 57835e1 Compare July 2, 2019 07:18
@oliviertassinari oliviertassinari requested a review from eps1lon July 2, 2019 07:19
@oliviertassinari oliviertassinari force-pushed the docs-ad-small-information branch from 57835e1 to 7f088bc Compare July 2, 2019 17:45
@oliviertassinari oliviertassinari merged commit 22ea5ae into mui:master Jul 3, 2019
@oliviertassinari oliviertassinari deleted the docs-ad-small-information branch July 3, 2019 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants