[core] Improve test coverage #16453
Merged
[core] Improve test coverage #16453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 3bbf941...114bc4f |
eps1lon
force-pushed
the
test/testing-library-migration
branch
3 times, most recently
from
165ee08 to
0ad86f6
Compare
eps1lon
commented
Jul 3, 2019
| assert.strictEqual(handleEmpty.callCount, 1); | ||
| assert.strictEqual(muiFormControl.onEmpty.callCount, 2); | ||
| fireEvent.change(container.querySelector('input'), { target: { value: '' } }); | ||
| expect(handleEmpty.callCount).to.equal(2); |
There was a problem hiding this comment.
Was 1 is now 2 because of implicit act. Those values don't really make sense to me right now but I will follow-up on this because the current behavior probably causes #16458.
eps1lon
commented
Jul 3, 2019
| <ListItem> | ||
| <ListItemText primary="primary" /> | ||
| <ListItemSecondaryAction /> | ||
| </ListItem>, | ||
| ); | ||
| const listItem = findOutermostIntrinsic(wrapper); | ||
| assert.strictEqual(listItem.hasClass(classes.container), true); | ||
| assert.strictEqual(wrapper.find('li > div').exists(), true); |
There was a problem hiding this comment.
This didn't do what it was intended to do since it also matched <li><span /><div /></li> which is important for the next test.
eps1lon
force-pushed
the
test/testing-library-migration
branch
from
0ad86f6 to
114bc4f
Compare
1 task
joshwooding
approved these changes
Jul 4, 2019
| expect(root).to.have.class(classes.sizeSmall); | ||
|
|
||
| root = render(<IconButton size="medium">book</IconButton>).container.firstChild; | ||
| expect(root).not.to.have.class(classes.sizeSmall); |
There was a problem hiding this comment.
I know you copied the previous tests but, should we test that the medium class has been applied?
There was a problem hiding this comment.
There is no medium class. It's one of the issues I have with moving default styles to root instead their actual variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts all tests for components applying density. I'm touching the test anyway for #16410 so that's always a good time for refactoring.