Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve example of Custom Pagination Actions Table #16472

Merged
merged 3 commits into from
Jul 5, 2019

Conversation

bigtone1284
Copy link
Contributor

@bigtone1284 bigtone1284 commented Jul 3, 2019

Closes #16360

Updated the example to return to the first page when the row count is changed. See issue for steps to reproduce the bug.

@mui-pr-bot
Copy link

mui-pr-bot commented Jul 3, 2019

No bundle size changes comparing 3bbf941...5cfe026

Generated by 🚫 dangerJS against 5cfe026

@oliviertassinari oliviertassinari changed the title [docs] - improve example of Custom Pagination Actions Table [docs] Improve example of Custom Pagination Actions Table Jul 3, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior looks good to me. Shouldn't we fix this demo too https://material-ui.com/components/tables/#sorting-amp-selecting?

@oliviertassinari oliviertassinari added component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Jul 3, 2019
@oliviertassinari
Copy link
Member

@bigtone1284 Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table Pagination display numbers off
3 participants