Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ripple] Use custom transition logic #16525

Merged
merged 6 commits into from
Jul 9, 2019
Merged

[Ripple] Use custom transition logic #16525

merged 6 commits into from
Jul 9, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jul 9, 2019 •
edited
Loading

Review per-commit is advised.

Reduces implementation logic (remove unused className and enter delay). We only ever needed the exit transition for which we don't need a complete Transition component. This makes Ripple StrictMode compatible which cascades to a lot of components since ButtonBase only uses TransitionGroup which is StrictMode compatible as of react-transition-group@^4.0.0.

Also reduces the number of commits (no more enter transition which was never needed as far as I can tell).

@eps1lon eps1lon added performance package: material-ui Specific to @mui/material labels Jul 9, 2019
@eps1lon eps1lon added this to the 16.8 React.StrictMode milestone Jul 9, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 9, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 2cceffb...5499a0d

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.01% -0.02% 327,461 327,440 90,340 90,326
@material-ui/core/Paper 0.00% +0.04% 🔺 68,438 68,438 20,386 20,394
@material-ui/core/Paper.esm -0.00% 0.00% 61,722 61,721 19,178 19,178
@material-ui/core/Popper 0.00% -0.01% 28,942 28,942 10,408 10,407
@material-ui/core/Textarea 0.00% 0.00% 5,505 5,505 2,365 2,365
@material-ui/core/TrapFocus 0.00% 0.00% 3,753 3,753 1,576 1,576
@material-ui/core/styles/createMuiTheme 0.00% -0.02% 16,160 16,160 5,814 5,813
@material-ui/core/useMediaQuery 0.00% +0.09% 🔺 2,595 2,595 1,103 1,104
@material-ui/lab -0.02% -0.01% 138,044 138,023 42,540 42,537
@material-ui/styles 0.00% +0.05% 🔺 51,847 51,847 15,364 15,371
@material-ui/system 0.00% -0.02% 15,576 15,576 4,434 4,433
Button -4.10% -3.85% 84,590 81,121 25,759 24,768
Modal -0.01% +0.12% 🔺 14,515 14,514 5,088 5,094
Portal 0.00% 0.00% 3,471 3,471 1,573 1,573
Slider -0.00% +0.01% 🔺 75,124 75,123 23,302 23,304
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 54,338 54,338 13,762 13,762
docs.main -0.01% -0.02% 648,028 647,952 204,205 204,174
packages/material-ui/build/umd/material-ui.production.min.js -0.00% +0.01% 🔺 299,867 299,853 85,931 85,939

Generated by 🚫 dangerJS against 5499a0d

@eps1lon eps1lon marked this pull request as ready for review July 9, 2019 10:05
@eps1lon eps1lon requested a review from oliviertassinari July 9, 2019 10:05
oliviertassinari
oliviertassinari approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@eps1lon eps1lon merged commit 86de525 into mui:master Jul 9, 2019
@eps1lon eps1lon deleted the feat/rtg-less branch July 9, 2019 17:29
@oliviertassinari
Copy link
Member

I wish we were tracking the bundle size of the Button. I'm sure this has helped :)

@eps1lon
Copy link
Member Author

eps1lon commented Jul 9, 2019

I wish we were tracking the bundle size of the Button. I'm sure this has helped :)

Button -4.10% | -3.85% | 84,590 | 81,121 | 25,759 | 24,768

@oliviertassinari
Copy link
Member

Oh yes, we do! I was expecting to see the diff in the summary :), well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
package: material-ui Specific to @mui/material performance
Projects
None yet
Milestone
React.StrictMode
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari