[core] Restrict setRef usage to ref callback #16539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Jul 9, 2019
| @@ -68,7 +68,7 @@ describe('useScrollTrigger', () => { | |||
| assert.strictEqual(values.callCount, 1); | |||
| }); | |||
|
|
|||
| it('should be false by default when using setRef', () => { | |||
There was a problem hiding this comment.
I don't understand how this relates to setRef. Probably resolved during PR review?
|
No bundle size changes comparing c6fc068...e18ac8f |
oliviertassinari
approved these changes
Jul 9, 2019
joshwooding
approved these changes
Jul 9, 2019
or usage where extra care is taken of cleanup
eps1lon
force-pushed
the
feat/internal-setRef
branch
from
46b1fe2 to
e18ac8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
or usage where extra care is taken of cleanup
Closes #13539