Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[useFormControl] rename interface FormControl to FormControlState #16748

Merged
merged 1 commit into from
Jul 26, 2019
Merged

[useFormControl] rename interface FormControl to FormControlState #16748

merged 1 commit into from
Jul 26, 2019

Conversation

zoltanbedi
Copy link
Contributor

This pr fixes #16747

@mui-pr-bot
Copy link

No bundle size changes comparing cc47a27...47b85b3

Generated by 🚫 dangerJS against 47b85b3

eps1lon
eps1lon approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically breaking for Typescript users but we haven't really announced/documented it. Should be fine.

@oliviertassinari oliviertassinari merged commit 690e00c into mui:master Jul 26, 2019
@zoltanbedi zoltanbedi deleted the form-control-interface-rename branch July 26, 2019 16:36
@snyk-bot snyk-bot mentioned this pull request Sep 4, 2019
Open
@oliviertassinari oliviertassinari added the component: text field This is the name of the generic UI component, not the React module! label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eslint warning becasue of FormControl export
4 participants
@zoltanbedi @mui-pr-bot @eps1lon @oliviertassinari