Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Box] Forward props into cloned element #16882

Merged
merged 2 commits into from
Aug 6, 2019

Conversation

RostyslavKravchenko
Copy link
Contributor

@RostyslavKravchenko RostyslavKravchenko commented Aug 4, 2019

@oliviertassinari I'm opening the PR based on discussion #16475 (comment)

Closes #16475

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 4, 2019

Details of bundle changes.

Comparing: 14e595f...a48c279

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% -0.01% 329,716 329,727 90,142 90,136
@material-ui/core/Paper +0.02% 🔺 -0.00% 68,673 68,684 20,470 20,469
@material-ui/core/Paper.esm 0.00% 0.00% 62,058 62,058 19,209 19,209
@material-ui/core/Popper 0.00% 0.00% 29,185 29,185 10,434 10,434
@material-ui/core/Textarea 0.00% 0.00% 5,759 5,759 2,368 2,368
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,617 1,617
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,389 16,389 5,824 5,824
@material-ui/core/useMediaQuery 0.00% 0.00% 3,221 3,221 1,312 1,312
@material-ui/lab 0.00% 0.00% 152,604 152,604 46,521 46,521
@material-ui/styles +0.02% 🔺 -0.01% 51,390 51,401 15,286 15,285
@material-ui/system 0.00% 0.00% 15,753 15,753 4,380 4,380
Button 0.00% 0.00% 79,426 79,426 24,280 24,280
Modal 0.00% 0.00% 15,050 15,050 5,233 5,233
Portal 0.00% 0.00% 3,579 3,579 1,568 1,568
Rating 0.00% 0.00% 70,735 70,735 22,079 22,079
Slider 0.00% 0.00% 75,071 75,071 23,272 23,272
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 52,044 52,044 13,816 13,816
docs.main 0.00% 0.00% 590,655 590,655 188,786 188,786
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 299,810 299,811 86,177 86,179

Generated by 🚫 dangerJS against a48c279

@oliviertassinari oliviertassinari changed the title [styles] Passed props into cloned elements [styles] Forward props into cloned elements Aug 4, 2019
@oliviertassinari oliviertassinari changed the title [styles] Forward props into cloned elements [styles] Forward props into cloned element Aug 4, 2019
@oliviertassinari oliviertassinari added the component: Box The React component. label Aug 4, 2019
@oliviertassinari oliviertassinari changed the title [styles] Forward props into cloned element [Box] Forward props into cloned element Aug 4, 2019
@joshwooding joshwooding merged commit dc740b6 into mui:master Aug 6, 2019
@joshwooding
Copy link
Member

@RostyslavKravchenko Well done! This is a great first pull request on Material-UI. Thanks for working on it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Box The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box clone ignores SyntheticEvent
4 participants