Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popper] Fix ScrollPlayground.js demo #16948

Merged
merged 2 commits into from
Aug 9, 2019
Merged

Conversation

pinktig
Copy link
Contributor

@pinktig pinktig commented Aug 9, 2019

Thanks for your hardwork!
This is proposed change for popper documentation following the #16944.

Closes #16944.

Thanks for your hardwork! 
This is proposed change for popper documentation following the mui#16944.
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: Popper The React component. See <Popup> for the latest version. docs Improvements or additions to the documentation labels Aug 9, 2019
@oliviertassinari oliviertassinari changed the title Update ScrollPlayground.js [Popper] Fix ScrollPlayground.js demo Aug 9, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 9, 2019

No bundle size changes comparing c5b518b...bf89fab

Generated by 🚫 dangerJS against bf89fab

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@oliviertassinari
Copy link
Member

@pinktig It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: Popper The React component. See <Popup> for the latest version. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime error on Popper component documentation
3 participants