Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Refresh material icons #17259

Merged
merged 2 commits into from
Sep 5, 2019
Merged

[icons] Refresh material icons #17259

merged 2 commits into from
Sep 5, 2019

Conversation

colemars
Copy link
Contributor

@colemars colemars commented Sep 1, 2019

Google has updated quite a few of their Icons and they've added some new ones as well.

This refresh will put @material-ui/icons in sync with https://material.io/resources/icons/ while also keeping icons currently in use by @material-ui/icons but deprecated by google.

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 1, 2019

Details of bundle changes.

Comparing: ce4d844...4a515a7

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 331,220 331,220 90,473 90,473
@material-ui/core/Paper 0.00% 0.00% 68,774 68,774 20,485 20,485
@material-ui/core/Paper.esm 0.00% 0.00% 62,148 62,148 19,214 19,214
@material-ui/core/Popper 0.00% 0.00% 28,466 28,466 10,188 10,188
@material-ui/core/Textarea 0.00% 0.00% 5,094 5,094 2,135 2,135
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,617 1,617
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,385 16,385 5,827 5,827
@material-ui/core/useMediaQuery 0.00% 0.00% 2,541 2,541 1,058 1,058
@material-ui/lab 0.00% 0.00% 153,209 153,209 46,684 46,684
@material-ui/styles 0.00% 0.00% 51,494 51,494 15,304 15,304
@material-ui/system 0.00% 0.00% 15,668 15,668 4,361 4,361
Button 0.00% 0.00% 78,663 78,663 24,048 24,048
Modal 0.00% 0.00% 14,335 14,335 5,013 5,013
Portal 0.00% 0.00% 2,907 2,907 1,322 1,322
Rating 0.00% 0.00% 70,016 70,016 21,864 21,864
Slider 0.00% 0.00% 74,282 74,282 23,015 23,015
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 52,253 52,253 13,780 13,780
docs.main -0.02% -0.09% 597,376 597,278 190,809 190,646
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 302,086 302,086 86,797 86,797

Generated by 🚫 dangerJS against 4a515a7

@mbrookes mbrookes added the package: icons Specific to @mui/icons label Sep 1, 2019
@oliviertassinari oliviertassinari self-assigned this Sep 2, 2019
@colemars

This comment has been minimized.

@oliviertassinari oliviertassinari removed their assignment Sep 3, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed it a bit further

@colemars

This comment has been minimized.

@merceyz
Copy link
Member

merceyz commented Sep 3, 2019

Multiple commits are not an issue, that's what squash and merge is for.
You could always just reset the commit, make the changes and then force push to replace the old commit

@colemars

This comment has been minimized.

@colemars colemars closed this Sep 4, 2019
@colemars colemars reopened this Sep 4, 2019
@colemars
Copy link
Contributor Author

colemars commented Sep 5, 2019

I believe this should be good to go - apologies for the log mess.

@oliviertassinari oliviertassinari merged commit 833738d into mui:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: icons Specific to @mui/icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants