[docs] Improve the documentation covering react-router #17343
Conversation
|
No bundle size changes comparing 0ddd56f...44ee082 |
oliviertassinari
changed the title
There was a problem hiding this comment.
We also have a live demo with React Router under https://material-ui.com/components/buttons/#third-party-routing-library
@mbrookes has recently raised the existence of an opportunity to make the button's react-router section easier to understand.
What do you guys think of consolidation this concern under https://material-ui.com/guides/composition/#react-router-demo? We could link the guide from each component page, where appropriate.
I like that. Especially since there are plenty of components that are interested in an integration (e.g. generic Links, nav menus, nav treeviews, nav anything basically). |
|
@oliviertassinari I was thinking that too, as MenuItem is not the only use case. Would make much more sense your suggested approach. |
|
Is this OK with you guys if I continue this pull request to implement the proposed approach? |
It would be ideal for me as I didn't find time in-between work and personal life, you're a star 🌟 |
Add example regarding the use of Link from react-router-dom to be used with MenuItem as the documentation was missing this bit and online resources were not easy to find. (neither is deductible, to me at least).
oliviertassinari
force-pushed
the
patch-2
branch
from
0475b87 to
e56b717
Compare
oliviertassinari
force-pushed
the
patch-2
branch
from
e56b717 to
227d02d
Compare
docs/src/pages/getting-started/example-projects/example-projects.md
Outdated
Show resolved
Hide resolved
oliviertassinari
force-pushed
the
patch-2
branch
from
9969bc0 to
693a31a
Compare
oliviertassinari
changed the title
|
@MelMacaluso Thank you! |
Add example regarding the use of Link from react-router-dom to be used with MenuItem as the documentation was missing this bit and online resources were not easy to find. (neither is deductible, to me at least).