Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Warn when changing between controlled uncontrolled #17422

Merged
merged 6 commits into from
Sep 15, 2019
Merged

[core] Warn when changing between controlled uncontrolled #17422

merged 6 commits into from
Sep 15, 2019

Conversation

kmhigashioka
Copy link
Contributor

@kmhigashioka kmhigashioka commented Sep 14, 2019 •
edited
Loading

Fixes #17399

@kmhigashioka kmhigashioka marked this pull request as ready for review September 14, 2019 06:44
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 14, 2019 •
edited
Loading

Details of bundle changes.

Comparing: c6f9fab...75092c0

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% -0.02% 331,593 331,597 90,510 90,490
@material-ui/core/Paper 0.00% 0.00% 68,644 68,644 20,449 20,449
@material-ui/core/Paper.esm 0.00% 0.00% 62,083 62,083 19,192 19,192
@material-ui/core/Popper 0.00% 0.00% 28,397 28,397 10,159 10,159
@material-ui/core/Textarea 0.00% 0.00% 5,082 5,082 2,132 2,132
@material-ui/core/TrapFocus 0.00% 0.00% 3,766 3,766 1,596 1,596
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,333 16,333 5,808 5,808
@material-ui/core/useMediaQuery 0.00% 0.00% 2,488 2,488 1,050 1,050
@material-ui/lab 0.00% 0.00% 153,553 153,553 46,724 46,724
@material-ui/styles 0.00% 0.00% 51,420 51,420 15,288 15,288
@material-ui/system 0.00% 0.00% 15,581 15,581 4,351 4,351
Button 0.00% 0.00% 78,595 78,595 24,014 24,014
Modal 0.00% 0.00% 14,527 14,527 5,102 5,102
Portal 0.00% 0.00% 2,907 2,907 1,318 1,318
Rating 0.00% 0.00% 69,948 69,948 21,844 21,844
Slider 0.00% 0.00% 75,069 75,069 23,173 23,173
colorManipulator 0.00% 0.00% 3,835 3,835 1,519 1,519
docs.landing 0.00% 0.00% 52,232 52,232 13,768 13,768
docs.main 0.00% 0.00% 597,111 597,111 190,621 190,621
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 302,533 302,533 86,930 86,930

Generated by 🚫 dangerJS against 75092c0

@oliviertassinari oliviertassinari mentioned this pull request Sep 14, 2019
Closed
1 task
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Sep 14, 2019
@oliviertassinari oliviertassinari force-pushed the component/warn-when-changing-between-controlled-uncontrolled branch from 3ad3c3d to cc81ab0 Compare September 14, 2019 11:15
@oliviertassinari oliviertassinari force-pushed the component/warn-when-changing-between-controlled-uncontrolled branch 2 times, most recently from 2c180cb to 0bbc426 Compare September 14, 2019 14:40
@oliviertassinari oliviertassinari force-pushed the component/warn-when-changing-between-controlled-uncontrolled branch from 0bbc426 to 75092c0 Compare September 14, 2019 20:13
@oliviertassinari oliviertassinari merged commit 9454535 into mui:master Sep 15, 2019
@oliviertassinari
Copy link
Member

@kmhigashioka It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@kmhigashioka
Copy link
Contributor Author

@oliviertassinari Thank you very much for your help! Would love to contribute again. 🙂

@kmhigashioka kmhigashioka deleted the component/warn-when-changing-between-controlled-uncontrolled branch February 11, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merceyz merceyz merceyz left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core] Warn when changing between controlled and uncontrolled
4 participants
@kmhigashioka @mui-pr-bot @oliviertassinari @merceyz