[docs] Add demo for vertical dividers #17457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing e48aeba...39314ed |
mbrookes
reviewed
Sep 16, 2019
oliviertassinari
force-pushed
the
vertical-divider-demo
branch
from
6b4be64 to
fc1e20d
Compare
oliviertassinari
added
component: divider
oliviertassinari
force-pushed
the
vertical-divider-demo
branch
2 times, most recently
from
2dac49f to
3496ab8
Compare
oliviertassinari
force-pushed
the
vertical-divider-demo
branch
from
3496ab8 to
39314ed
Compare
|
@nrkroeker They are a couple of different changes we could explore for this component. For the vertical support, a flex strength (as in the toggle button) or font size based height (https://ant.design/components/divider/#components-divider-demo-vertical) could work too. On a different note, the children support of Semantic is interesting: https://react.semantic-ui.com/elements/divider/#types-horizontal. |
|
@nrkroeker Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt 2 xD
Made a simpler version of the example which is now in toggle buttons and tried to keep it as light as possible. Figured it'd be good to get at least something visible for the vertical functionality so other folks find it easier.