-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Use Button for language menu #17487
Conversation
mbrookes
commented
Sep 19, 2019
- I have followed (at least) the PR section of the contributing guide.
Details of bundle changes.Comparing: ccc470e...de42fab
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that 👍
Personally I prefer the option showing the currently selected language. It more closely follows the spec for menus used for item selection: https://material.io/components/menus/#exposed-dropdown-menu The flag is a pretty clear indicator of the menu's purpose if you find yourself viewing the docs in a language you don't understand. However since there was a preference for the word "language" instead, I have no idea what the right thing to do is vs localisation of that string. React localises it though, so perhaps we should follow suit? |
Flags can be hard to distinguish depending on size and background. Displaying the current value makes sense if you have a visible label. I think I prefer following react here so that it's immediately familiar for people coming from the react docs or vice versa. |
I like the argument of being close to React (of @eps1lon), the docusaurus approach is interesting too: https://docusaurus.io/en/. But no matter what we pick, it's probably not much different, these are all great options; @mbrookes I think that you can move forward with what you prefer, don't see much need in a long discussion here :) |
So, there is no common opinion on what to use for the text, if any: https://uxdesign.cc/my-take-on-language-selectors-945caceb58f7 ...but there is one common thread – don't use flags. I propose using the icon we have now, displaying the selected language (as per MD spec recommendation) with the text hidden at small screen sizes, and with the dropdown icon. We should also remove the flags. |
195f83d
to
4e2ce97
Compare
e19f7b3
to
7996d0e
Compare
Awesome |