Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextareaAutosize] Improve line computation and avoid infinite loop #17652

Conversation

neon98
Copy link
Contributor

@neon98 neon98 commented Oct 1, 2019

fixes #17385

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 1, 2019

Details of bundle changes.

Comparing: 09ec808...d1b0e01

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.01% 🔺 +0.01% 🔺 334,392 334,416 91,184 91,189
@material-ui/core/Paper 0.00% 0.00% 69,049 69,049 20,524 20,524
@material-ui/core/Paper.esm 0.00% 0.00% 62,377 62,377 19,276 19,276
@material-ui/core/Popper 0.00% 0.00% 28,405 28,405 10,179 10,179
@material-ui/core/Textarea +0.47% 🔺 +0.70% 🔺 5,082 5,106 2,134 2,149
@material-ui/core/TrapFocus 0.00% 0.00% 3,766 3,766 1,597 1,597
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,351 16,351 5,821 5,821
@material-ui/core/useMediaQuery 0.00% 0.00% 2,488 2,488 1,052 1,052
@material-ui/lab 0.00% 0.00% 143,406 143,406 43,818 43,818
@material-ui/styles 0.00% 0.00% 51,780 51,780 15,355 15,355
@material-ui/system 0.00% 0.00% 15,583 15,583 4,339 4,339
Button 0.00% 0.00% 79,148 79,148 24,122 24,122
Modal 0.00% 0.00% 14,542 14,542 5,113 5,113
Portal 0.00% 0.00% 2,907 2,907 1,316 1,316
Rating 0.00% 0.00% 70,239 70,239 21,941 21,941
Slider 0.00% 0.00% 75,380 75,380 23,272 23,272
colorManipulator 0.00% 0.00% 3,835 3,835 1,519 1,519
docs.landing 0.00% 0.00% 54,267 54,267 14,344 14,344
docs.main 0.00% 0.00% 588,954 588,954 188,297 188,297
packages/material-ui/build/umd/material-ui.production.min.js +0.01% 🔺 +0.01% 🔺 305,347 305,371 87,830 87,841

Generated by 🚫 dangerJS against d1b0e01

@oliviertassinari oliviertassinari added component: TextareaAutosize The React component. bug 🐛 Something doesn't work labels Oct 1, 2019
@oliviertassinari oliviertassinari changed the title [TextareaAutosize] Fix issue with Meiryo font in TextareaAutosize in Firefox [TextareaAutosize] Improve line computation and avoid infinite loop Oct 1, 2019
@oliviertassinari oliviertassinari force-pushed the bugfix/TextareaAutosize-font-in-firefox-issue branch from a218945 to a127211 Compare October 1, 2019 10:29
@oliviertassinari
Copy link
Member

@neon98 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: TextareaAutosize The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invariant Violation Maximum update depth exceeded on TextareaAutosize with Meiryo font in Firefox
3 participants