-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add ScaffoldHub to ads and example projects #18071
Conversation
mbrookes
commented
Oct 27, 2019
- I have followed (at least) the PR section of the contributing guide.
Details of bundle changes.Comparing: 373ecdd...487fddc
|
d48c7f8
to
a38d999
Compare
3b1663c
to
55ec057
Compare
55ec057
to
487fddc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the custom ads to use a generic template we can feed in data. I hope it will help in the future.
href={ad.link} | ||
// eslint-disable-next-line react/jsx-no-target-blank | ||
target="_blank" | ||
rel="nofollow noopener" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you refresh my mind why we do this? It's not user generated content so the spam rationale doesn't apply, no?
Otherwise reading https://support.google.com/webmasters/answer/96569?hl=en we maybe want to use sponsored
instead. Otherwise I don't understand why we wouldn't want to be associated with that site if we authored the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eps1lon Thanks for linking this SEO news! It has been a long time since Google changed it.
Carbon and CodeFund use "noopener" for security reasons. Carbon should have been using "nofollow" (only CodeFund did). Given
Google also required nofollow for paid or sponsored links. If you were caught accepting anything of value in exchange for linking out without the nofollow attribute, Google could penalize you.
https://moz.com/blog/nofollow-sponsored-ugc. I will notify Carbon and CodeFund so they start to use the sponsored
value.
I also think that we should do a follow-up PR to use sponsored where appropriate. I have added it in the list of small changes to batch, that I can handle unless somebody wants to take care of it. I have noticed that Vue already uses rel="sponsored noopener"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When things go wrong 🙃: https://www.brinzan.com/2019/09/apache-software-foundation-selling-links-for-seo/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah the noopener I do understand. I just don't understand the nofollow for links that obviously relate to our content. As I understood the google guidelines simply getting money from a linked page doesn't imply a link scheme. Only if we solely link because we got money. And as far as I can tell the linked content clearly relates to ours. Same for github or material.io. This is why I wanted this clarification.
For links to sponsors I completely understand using nofollow or better sponsored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I bring in extra information by saying that follow links have more weight than nofollow links in the search engine results pages (SERP) position?