Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lab] Bump material-ui/core version #18354

Merged
merged 1 commit into from
Nov 13, 2019
Merged

[lab] Bump material-ui/core version #18354

merged 1 commit into from
Nov 13, 2019

Conversation

renatoagds
Copy link
Contributor

@renatoagds renatoagds commented Nov 13, 2019 •
edited
Loading

Today, lab requires a minimum version of v4.6.1 in core, without it, Autocomplete breaks.

Because the change in useEventCallback, that now accepts a list of args instead just event.

Without this change, resetInputValue receives undefined in newValue and set the value to empty.

@mui-pr-bot
Copy link

No bundle size changes comparing 45779b9...277ca93

Generated by 🚫 dangerJS against 277ca93

@oliviertassinari oliviertassinari changed the title [lab]: Bump material-ui/core version [lab] Bump material-ui/core version Nov 13, 2019
@oliviertassinari oliviertassinari merged commit e0dd45f into mui:master Nov 13, 2019
@oliviertassinari
Copy link
Member

@renatoagds Thanks for the fix!

@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Nov 13, 2019
@renatoagds renatoagds deleted the fix-lab-dependencies branch November 13, 2019 20:42
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renatoagds @mui-pr-bot @oliviertassinari