Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Increase interaction area #18429

Merged
merged 2 commits into from
Nov 20, 2019
Merged

[Slider] Increase interaction area #18429

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8e0814
[Slider] Increase interaction area and keep thumb in parent boundaries
oliviertassinari Nov 18, 2019
68d5c5e
Increase thumb area by 2px
oliviertassinari Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions packages/material-ui/src/Slider/Slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export const styles = theme => ({
height: 2,
width: '100%',
boxSizing: 'content-box',
padding: '11px 0',
padding: '13px 0',
display: 'inline-block',
position: 'relative',
cursor: 'pointer',
Expand All @@ -152,7 +152,7 @@ export const styles = theme => ({
'&$vertical': {
width: 2,
height: '100%',
padding: '0 11px',
padding: '0 13px',
},
// The primary input mechanism of the device includes a pointing device of limited accuracy.
'@media (pointer: coarse)': {
Expand Down Expand Up @@ -247,11 +247,12 @@ export const styles = theme => ({
'&::after': {
position: 'absolute',
content: '""',
// reach 48px touch target (2 * 18 + thumb circumference)
left: -18,
top: -18,
right: -18,
bottom: -18,
borderRadius: '50%',
// x10 thumb surface (from 12px^2 to 40px^2).
oliviertassinari marked this conversation as resolved.
Show resolved Hide resolved
left: -14,
oliviertassinari marked this conversation as resolved.
Show resolved Hide resolved
top: -14,
right: -14,
bottom: -14,
},
'&$focusVisible,&:hover': {
boxShadow: `0px 0px 0px 8px ${fade(theme.palette.primary.main, 0.16)}`,
Expand Down Expand Up @@ -317,12 +318,12 @@ export const styles = theme => ({
...theme.typography.body2,
color: theme.palette.text.secondary,
position: 'absolute',
top: 22,
top: 26,
transform: 'translateX(-50%)',
whiteSpace: 'nowrap',
'$vertical &': {
top: 'auto',
left: 22,
left: 26,
transform: 'translateY(50%)',
},
'@media (pointer: coarse)': {
Expand Down