Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ToggleButton] Add size prop type definition #18778

Merged
merged 2 commits into from
Dec 10, 2019
Merged

[ToggleButton] Add size prop type definition #18778

merged 2 commits into from
Dec 10, 2019

Conversation

sarfata
Copy link
Contributor

@sarfata sarfata commented Dec 10, 2019

The size attribute for ToggleButton was missing in the types definition. This adds it.

I have also ran yarn typescript and confirmed it passes.

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 10, 2019 •
edited
Loading

No bundle size changes comparing 37428d5...be66186

Generated by 🚫 dangerJS against be66186

@oliviertassinari oliviertassinari changed the title [ToggleButton] (Typescript) add size attribute [ToggleButton] Add size prop type definition Dec 10, 2019
@oliviertassinari oliviertassinari added component: toggle button This is the name of the generic UI component, not the React module! typescript labels Dec 10, 2019
@oliviertassinari oliviertassinari merged commit 333749d into mui:master Dec 10, 2019
@oliviertassinari
Copy link
Member

@sarfata Thanks for the fix!

@sarfata sarfata deleted the sarfata/togglebutton-ts-size branch December 11, 2019 09:20
@oliviertassinari oliviertassinari mentioned this pull request Dec 12, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: toggle button This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarfata @mui-pr-bot @oliviertassinari