Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix broken TypeScript hash link in CONTRIBUTING.md #19236

Merged
merged 2 commits into from
Jan 15, 2020
Merged

[docs] Fix broken TypeScript hash link in CONTRIBUTING.md #19236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a59b237
[docs]: Remove typescript demo link from CONTRIBUTING.md
hiteshkundal Jan 14, 2020
c3a603e
Update CONTRIBUTING.md
oliviertassinari Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ yarn install

```sh
git checkout -b my-topic-branch
````
```

6. Make changes, commit and push to your fork:

Expand Down Expand Up @@ -92,7 +92,7 @@ Because we will only merge a Pull Request for which all tests pass. The followin
- The code is linted (run `yarn lint`).
- If API documentation is being changed in the source (run `yarn docs:api`).
- If demos were changed, make sure `yarn docs:typescript:formatted` does not introduce changes.
See [About TypeScript demos](#about-typescript-demos).
See [about writing demos](#3-write-the-content-of-the-demo).
- The Pull Request title follows the pattern `[Component] Imperative commit message`. (See: [How to Write a Git Commit Message](https://chris.beams.io/posts/git-commit/#imperative) for a great explanation)

#### Checks and how to fix them
Expand Down