-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Switch] Ref attribute fix (width bug) #19662
Conversation
Details of bundle changes.Comparing: dbc1aee...fb334a4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking on this issue. Now, I wonder if it's actually the best course of action. We would return the ref from the root element but spread the props on the input. Maybe we should wait for v5 to clear that up? @eps1lon
Well I had that in the back of my head but honestly wanted to avoid any further discussion about what the "root element" is. Looking at this now it makes more sense to say -Any other props supplied will be provided to the root element (IconButton).
+Any other props supplied will be provided to the IconButton. and explain what we mean by But then again this is inconsistent once Now I'm not even sure about this change. If you're interested in the bounding box then this is a fix. But if you want to programmatically focus the component this is a breaking change (though with a workaround by using |
Yeah, great point. Let's have ref and the spread on the same element, we can revisit it in v5. |
@captain-yossarian Thanks for taking the time to look into this :) |
Closes #19613