-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Typography] Add warning, info and success color options #20001
Conversation
andriijas
commented
Mar 5, 2020
- I have followed (at least) the PR section of the contributing guide.
Details of bundle changes.Comparing: e25b7d5...89ad186 Details of page changes
|
@@ -14,6 +14,9 @@ const TypographyTest = () => { | |||
<Typography align="inherit" color="textSecondary" /> | |||
<Typography align="inherit" color="error" /> | |||
// $ExpectError | |||
<Typography align="inherit" color="warning" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move those down so that "new tests" = "last tests"? Right now an old test no longer expects an error while a new one does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eps1lon fixed. there is just one error in circleci now, nopt sure what it means though
Continuing the discussion in #21958. @andriijas thanks for the effort! |