[test] Match against messages not args on console methods

package.json

@@ -101,6 +101,7 @@
     "eslint-plugin-react": "^7.14.3",
     "eslint-plugin-react-hooks": "^2.1.1",
     "expect-puppeteer": "^4.3.0",
+    "format-util": "^1.0.5",
     "fs-extra": "^8.1.0",
     "glob": "^7.1.2",
     "glob-gitignore": "^1.0.11",

packages/material-ui-lab/src/Autocomplete/Autocomplete.test.js

@@ -777,7 +777,7 @@ describe('<Autocomplete />', () => {
       expect(handleChange.callCount).to.equal(1);
       expect(handleChange.args[0][1]).to.equal('a');
       expect(consoleErrorMock.callCount()).to.equal(2); // strict mode renders twice
-      expect(consoleErrorMock.args()[0][0]).to.include(
+      expect(consoleErrorMock.messages()[0]).to.include(
         'For the input option: "a", `getOptionLabel` returns: undefined',
       );
     });
@@ -806,7 +806,7 @@ describe('<Autocomplete />', () => {
       fireEvent.keyDown(document.activeElement, { key: 'Enter' });
 
       expect(consoleErrorMock.callCount()).to.equal(1); // strict mode renders twice
-      expect(consoleErrorMock.args()[0][0]).to.include(
+      expect(consoleErrorMock.messages()[0]).to.include(
         'The component expects a single value to match a given option but found 2 matches.',
       );
     });

packages/material-ui-lab/src/TreeView/TreeView.test.js

@@ -45,7 +45,7 @@ describe('<TreeView />', () => {
       );
 
       setProps({ expanded: undefined });
-      expect(consoleErrorMock.args()[0][0]).to.include(
+      expect(consoleErrorMock.messages()[0]).to.include(
         'A component is changing a controlled TreeView to be uncontrolled',
       );
     });
@@ -58,7 +58,7 @@ describe('<TreeView />', () => {
       );
 
       setProps({ selected: undefined });
-      expect(consoleErrorMock.args()[0][0]).to.include(
+      expect(consoleErrorMock.messages()[0]).to.include(
         'A component is changing a controlled TreeView to be uncontrolled',
       );
     });

packages/material-ui-styles/src/StylesProvider/StylesProvider.test.js

@@ -161,7 +161,7 @@ describe('StylesProvider', () => {
       );
       assert.strictEqual(consoleErrorMock.callCount(), 1);
       assert.include(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         'you cannot use the jss and injectFirst props at the same time',
       );
     });

packages/material-ui-styles/src/ThemeProvider/ThemeProvider.test.js

@@ -144,7 +144,7 @@ describe('ThemeProvider', () => {
         </ThemeProvider>,
       );
       assert.strictEqual(consoleErrorMock.callCount(), 2); // twice in strict mode
-      assert.include(consoleErrorMock.args()[0][0], 'However, no outer theme is present.');
+      assert.include(consoleErrorMock.messages()[0], 'However, no outer theme is present.');
     });
 
     it('should warn about wrong theme function', () => {
@@ -158,7 +158,7 @@ describe('ThemeProvider', () => {
       );
       assert.strictEqual(consoleErrorMock.callCount(), 2);
       assert.include(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         'you should return an object from your theme function',
       );
     });

packages/material-ui-styles/src/makeStyles/makeStyles.test.js

@@ -93,7 +93,7 @@ describe('makeStyles', () => {
       assert.deepEqual(extendedClasses, { root: baseClasses.root, bar: 'undefined foo' });
       assert.strictEqual(consoleErrorMock.callCount(), 1);
       assert.include(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         'Material-UI: the key `bar` provided to the classes prop is not implemented',
       );
     });
@@ -102,9 +102,9 @@ describe('makeStyles', () => {
       const output = mountWithProps();
       output.wrapper.setProps({ classes: 'foo' });
       assert.strictEqual(consoleErrorMock.callCount() >= 1, true);
-      const args = consoleErrorMock.args();
+      const messages = consoleErrorMock.messages();
       assert.include(
-        consoleErrorMock.args()[args.length - 1][0],
+        messages[messages.length - 1],
         'You might want to use the className prop instead',
       );
     });
@@ -117,7 +117,7 @@ describe('makeStyles', () => {
       assert.deepEqual(extendedClasses, { root: `${baseClasses.root} [object Object]` });
       assert.strictEqual(consoleErrorMock.callCount(), 1);
       assert.include(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         'Material-UI: the key `root` provided to the classes prop is not valid',
       );
     });
@@ -129,7 +129,7 @@ describe('makeStyles', () => {
         mountWithProps2({});
       });
       assert.strictEqual(consoleErrorMock.callCount(), 4);
-      assert.include(consoleErrorMock.args()[1][0], 'the `styles` argument provided is invalid');
+      assert.include(consoleErrorMock.messages()[1], 'the `styles` argument provided is invalid');
     });
   });
 

packages/material-ui-styles/src/styled/styled.test.js

@@ -108,7 +108,7 @@ describe('styled', () => {
       );
       assert.strictEqual(consoleErrorMock.callCount(), 1);
       assert.include(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         'You can not use the clone and component prop at the same time',
       );
     });

packages/material-ui-styles/src/withStyles/withStyles.test.js

@@ -91,7 +91,7 @@ describe('withStyles', () => {
 
     //     assert.strictEqual(consoleErrorMock.callCount(), 1);
     //     assert.include(
-    //       consoleErrorMock.args()[0][0],
+    //       consoleErrorMock.messages()[0],
     //       'Warning: Failed prop type: Material-UI: the `innerRef` prop is deprecated',
     //     );
     //   });

packages/material-ui-styles/src/withTheme/withTheme.test.js

@@ -99,7 +99,7 @@ describe('withTheme', () => {
 
         assert.strictEqual(consoleErrorMock.callCount(), 1);
         assert.include(
-          consoleErrorMock.args()[0][0],
+          consoleErrorMock.messages()[0],
           'Warning: Failed prop type: Material-UI: the `innerRef` prop is deprecated',
         );
       });

packages/material-ui-system/src/spacing.test.js

@@ -57,9 +57,9 @@ describe('spacing', () => {
       });
       assert.deepEqual(output, { padding: undefined });
       assert.strictEqual(consoleErrorMock.callCount(), 1);
-      assert.match(consoleErrorMock.args()[0][0], /the value provided \(3\) overflows\./);
-      assert.match(consoleErrorMock.args()[0][0], /The supported values are: \[0,3,5\]\./);
-      assert.match(consoleErrorMock.args()[0][0], /3 > 2, you need to add the missing values\./);
+      assert.match(consoleErrorMock.messages()[0], /the value provided \(3\) overflows\./);
+      assert.match(consoleErrorMock.messages()[0], /The supported values are: \[0,3,5\]\./);
+      assert.match(consoleErrorMock.messages()[0], /3 > 2, you need to add the missing values\./);
     });
 
     it('should warn if the theme transformer is invalid', () => {
@@ -72,11 +72,11 @@ describe('spacing', () => {
       assert.deepEqual(output, { padding: undefined });
       assert.strictEqual(consoleErrorMock.callCount(), 1);
       assert.match(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         /the `theme.spacing` value \(\[object Object\]\) is invalid\./,
       );
       assert.match(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         /It should be a number, an array or a function\./,
       );
     });

packages/material-ui-utils/src/chainPropTypes.test.js

@@ -43,6 +43,6 @@ describe('chainPropTypes', () => {
       componentName,
     );
     assert.strictEqual(consoleErrorMock.callCount(), 1);
-    assert.match(consoleErrorMock.args()[0][0], /something is wrong/);
+    assert.match(consoleErrorMock.messages()[0], /something is wrong/);
   });
 });

packages/material-ui-utils/src/elementAcceptingRef.test.js

@@ -55,7 +55,7 @@ describe('elementAcceptingRef', () => {
       assert.strictEqual(
         consoleErrorMock.callCount(),
         failsOnMount ? 1 : 0,
-        `but got '${consoleErrorMock.args()[0]}'`,
+        `but got '${consoleErrorMock.messages()[0]}'`,
       );
     }
 
@@ -132,7 +132,7 @@ describe('elementAcceptingRef', () => {
 
       assert.strictEqual(consoleErrorMock.callCount(), 1);
       assert.include(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         'Invalid props `children` supplied to `DummyComponent`. ' +
           `Expected an element that can hold a ref. ${hint}`,
       );
@@ -141,13 +141,13 @@ describe('elementAcceptingRef', () => {
     it('rejects undefined values when required', () => {
       checkPropType(undefined, true);
       assert.strictEqual(consoleErrorMock.callCount(), 1);
-      assert.include(consoleErrorMock.args()[0][0], 'marked as required');
+      assert.include(consoleErrorMock.messages()[0], 'marked as required');
     });
 
     it('rejects null values when required', () => {
       checkPropType(null, true);
       assert.strictEqual(consoleErrorMock.callCount(), 1);
-      assert.include(consoleErrorMock.args()[0][0], 'marked as required');
+      assert.include(consoleErrorMock.messages()[0], 'marked as required');
     });
 
     it('rejects function components', () => {

packages/material-ui-utils/src/elementTypeAcceptingRef.test.js

@@ -55,7 +55,7 @@ describe('elementTypeAcceptingRef', () => {
       assert.strictEqual(
         consoleErrorMock.callCount(),
         failsOnMount ? 1 : 0,
-        `but got '${consoleErrorMock.args()[0]}'`,
+        `but got '${consoleErrorMock.messages()[0]}'`,
       );
     }
 
@@ -132,7 +132,7 @@ describe('elementTypeAcceptingRef', () => {
 
       assert.strictEqual(consoleErrorMock.callCount(), 1);
       assert.include(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         'Invalid props `component` supplied to `DummyComponent`. ' +
           `Expected an element type that can hold a ref. ${hint}`,
       );

packages/material-ui/src/Breadcrumbs/Breadcrumbs.test.js

@@ -104,7 +104,7 @@ describe('<Breadcrumbs />', () => {
       expect(getAllByRole('listitem', { hidden: false })).to.have.length(4);
       expect(getByRole('list')).to.have.text('first/second/third/fourth');
       expect(consoleErrorMock.callCount()).to.equal(2); // strict mode renders twice
-      expect(consoleErrorMock.args()[0][0]).to.include(
+      expect(consoleErrorMock.messages()[0]).to.include(
         'you have provided an invalid combination of props to the Breadcrumbs.\nitemsAfterCollapse={2} + itemsBeforeCollapse={2} >= maxItems={3}',
       );
     });

packages/material-ui/src/ButtonBase/ButtonBase.test.js

@@ -934,7 +934,7 @@ describe('<ButtonBase />', () => {
       // cant match the error message here because flakiness with mocha watchmode
       render(<ButtonBase component={Component} />);
 
-      expect(consoleErrorMock.args()[0][0]).to.include(
+      expect(consoleErrorMock.messages()[0]).to.include(
         'Invalid prop `component` supplied to `ForwardRef(ButtonBase)`. Expected an element type that can hold a ref',
       );
     });

packages/material-ui/src/CardMedia/CardMedia.test.js

@@ -96,7 +96,7 @@ describe('<CardMedia />', () => {
 
       assert.strictEqual(consoleErrorMock.callCount(), 1);
       assert.include(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         'Material-UI: either `children`, `image`, `src` or `component` prop must be specified.',
       );
     });

packages/material-ui/src/ExpansionPanel/ExpansionPanel.test.js

@@ -165,7 +165,7 @@ describe('<ExpansionPanel />', () => {
 
         assert.throws(() => mount(<ExpansionPanel>{[]}</ExpansionPanel>));
         assert.strictEqual(consoleErrorMock.callCount(), 3);
-        assert.include(consoleErrorMock.args()[0][0], 'Material-UI: expected the first child');
+        assert.include(consoleErrorMock.messages()[0], 'Material-UI: expected the first child');
       });
 
       it('needs a valid element as the first child', () => {
@@ -176,7 +176,7 @@ describe('<ExpansionPanel />', () => {
         );
         assert.strictEqual(consoleErrorMock.callCount(), 1);
         assert.include(
-          consoleErrorMock.args()[0][0],
+          consoleErrorMock.messages()[0],
           "Material-UI: the ExpansionPanel doesn't accept a Fragment",
         );
       });
@@ -206,7 +206,7 @@ describe('<ExpansionPanel />', () => {
 
       wrapper.setProps({ expanded: undefined });
       assert.include(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         'A component is changing a controlled ExpansionPanel to be uncontrolled.',
       );
     });
@@ -216,7 +216,7 @@ describe('<ExpansionPanel />', () => {
 
       wrapper.setProps({ expanded: true });
       assert.include(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         'A component is changing an uncontrolled ExpansionPanel to be controlled.',
       );
     });

packages/material-ui/src/GridList/GridList.test.js

@@ -208,7 +208,7 @@ describe('<GridList />', () => {
 
       assert.strictEqual(consoleErrorMock.callCount(), 1);
       assert.include(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         "Material-UI: the GridList component doesn't accept a Fragment as a child.",
       );
     });

packages/material-ui/src/Hidden/HiddenCss.test.js

@@ -162,7 +162,7 @@ describe('<HiddenCss />', () => {
 
       assert.strictEqual(consoleErrorMock.callCount(), 1);
       assert.include(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         'Material-UI: unsupported props received by `<Hidden implementation="css" />`: xxlUp.',
       );
     });

packages/material-ui/src/IconButton/IconButton.test.js

@@ -142,7 +142,7 @@ describe('<IconButton />', () => {
         </IconButton>,
       );
       expect(consoleErrorMock.callCount()).to.equal(1);
-      expect(consoleErrorMock.args()[0][0]).to.include(
+      expect(consoleErrorMock.messages()[0]).to.include(
         'you are providing an onClick event listener',
       );
     });

packages/material-ui/src/InputAdornment/InputAdornment.test.js

@@ -151,7 +151,7 @@ describe('<InputAdornment />', () => {
           </FormControl>,
         );
         expect(consoleErrorMock.callCount()).to.equal(1);
-        expect(consoleErrorMock.args()[0][0]).to.equal(
+        expect(consoleErrorMock.messages()[0]).to.equal(
           'Material-UI: The `InputAdornment` variant infers the variant ' +
             'prop you do not have to provide one.',
         );

packages/material-ui/src/InputBase/InputBase.test.js

@@ -500,7 +500,7 @@ describe('<InputBase />', () => {
         );
 
         expect(consoleErrorMock.callCount()).to.eq(1);
-        expect(consoleErrorMock.args()[0][0]).to.include(
+        expect(consoleErrorMock.messages()[0]).to.include(
           'Material-UI: there are multiple InputBase components inside a FormControl.',
         );
       });

packages/material-ui/src/LinearProgress/LinearProgress.test.js

@@ -179,12 +179,12 @@ describe('<LinearProgress />', () => {
     it('should warn when not used as expected', () => {
       shallow(<LinearProgress variant="determinate" value={undefined} />);
       assert.strictEqual(consoleErrorMock.callCount(), 1);
-      assert.match(consoleErrorMock.args()[0][0], /Material-UI: you need to provide a value prop/);
+      assert.match(consoleErrorMock.messages()[0], /Material-UI: you need to provide a value prop/);
       shallow(<LinearProgress variant="buffer" value={undefined} />);
       assert.strictEqual(consoleErrorMock.callCount(), 3);
-      assert.match(consoleErrorMock.args()[1][0], /Material-UI: you need to provide a value prop/);
+      assert.match(consoleErrorMock.messages()[1], /Material-UI: you need to provide a value prop/);
       assert.match(
-        consoleErrorMock.args()[2][0],
+        consoleErrorMock.messages()[2],
         /Material-UI: you need to provide a valueBuffer prop/,
       );
     });

packages/material-ui/src/ListItem/ListItem.test.js

@@ -158,7 +158,7 @@ describe('<ListItem />', () => {
         );
 
         expect(consoleErrorMock.callCount()).to.equal(1);
-        expect(consoleErrorMock.args()[0][0]).to.include(
+        expect(consoleErrorMock.messages()[0]).to.include(
           'Warning: Failed prop type: Material-UI: you used an element',
         );
       });
@@ -167,7 +167,7 @@ describe('<ListItem />', () => {
         render(<ListItem component={NoContent} autoFocus />);
 
         expect(consoleErrorMock.callCount()).to.equal(1);
-        expect(consoleErrorMock.args()[0][0]).to.include(
+        expect(consoleErrorMock.messages()[0]).to.include(
           'Material-UI: unable to set focus to a ListItem whose component has not been rendered.',
         );
       });

packages/material-ui/src/Menu/Menu.test.js

@@ -249,7 +249,7 @@ describe('<Menu />', () => {
 
       assert.strictEqual(consoleErrorMock.callCount(), 2);
       assert.include(
-        consoleErrorMock.args()[0][0],
+        consoleErrorMock.messages()[0],
         "Material-UI: the Menu component doesn't accept a Fragment as a child.",
       );
     });

packages/material-ui/src/Modal/Modal.test.js

@@ -509,7 +509,7 @@ describe('<Modal />', () => {
         </Modal>,
       );
       assert.strictEqual(consoleErrorMock.callCount(), 1);
-      assert.match(consoleErrorMock.args()[0][0], /the modal content node does not accept focus/);
+      assert.match(consoleErrorMock.messages()[0], /the modal content node does not accept focus/);
     });
 
     it('should not attempt to focus nonexistent children', () => {

packages/material-ui/src/Paper/Paper.test.js

@@ -82,7 +82,7 @@ describe('<Paper />', () => {
 
     assert.strictEqual(consoleErrorMock.callCount(), 1);
     assert.include(
-      consoleErrorMock.args()[0][0],
+      consoleErrorMock.messages()[0],
       'Material-UI: this elevation `25` is not implemented.',
     );
   });