Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Add limitTags prop #20209

Merged
merged 5 commits into from
Mar 23, 2020
Merged

[Autocomplete] Add limitTags prop #20209

merged 5 commits into from
Mar 23, 2020

Conversation

netochaves
Copy link
Contributor

Closes #19137

This PR adds a new prop to handle the amount of items visible without focus.
image

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 21, 2020 •
edited
Loading

@material-ui/lab: parsed: +0.14% , gzip: +0.19%

Details of bundle changes.

Comparing: 7e1da61...fee1583

Details of page changes
bundle Size Change Size Gzip Change Gzip
/components/autocomplete ▲ +1 kB (+0.91% ) 111 kB -- -1 B
/api-docs/autocomplete ▲ +130 B (+3.34% ) 4.02 kB -- -1 B
/components/grid-list ▲ +100 B (+0.85% ) 11.9 kB -- -1 B
/guides/localization ▲ +100 B (+0.51% ) 19.8 kB -- -1 B
/api-docs/avatar ▲ +10 B (+0.63% ) 1.61 kB -- -1 B
/api-docs/button ▼ -10 B (-0.43% ) 2.32 kB -- -1 B
/api-docs/input-label ▼ -10 B (-0.55% ) 1.82 kB -- -1 B
/api-docs/menu ▼ -10 B (-0.47% ) 2.12 kB -- -1 B
/api-docs/tree-view ▲ +10 B (+0.60% ) 1.67 kB -- -1 B
/api-docs/svg-icon ▲ +10 B (+0.50% ) 2.01 kB -- -1 B
/components/pagination ▼ -10 B (-0.12% ) 8.1 kB -- -1 B
/_app -- 34.3 kB -- -1 B
/api-docs/alert-title -- 1.14 kB -- -1 B
/api-docs/alert -- 2.15 kB -- -1 B
/api-docs/app-bar -- 1.69 kB -- -1 B
/api-docs/avatar-group -- 1.26 kB -- -1 B
/api-docs/backdrop -- 1.38 kB -- -1 B
/api-docs/badge -- 1.88 kB -- -1 B
/api-docs/bottom-navigation-action -- 1.55 kB -- -1 B
/api-docs/bottom-navigation -- 1.43 kB -- -1 B
/api-docs/breadcrumbs -- 1.59 kB -- -1 B
/api-docs/button-base -- 2.08 kB -- -1 B
/api-docs/button-group -- 1.95 kB -- -1 B
/api-docs/card-action-area -- 1.32 kB -- -1 B
/api-docs/card-actions -- 1.22 kB -- -1 B
/api-docs/card-content -- 1.2 kB -- -1 B
/api-docs/card-header -- 1.53 kB -- -1 B
/api-docs/card-media -- 1.43 kB -- -1 B
/api-docs/card -- 1.25 kB -- -1 B
/api-docs/checkbox -- 2.07 kB -- -1 B
/api-docs/chip -- 2.19 kB -- -1 B
/api-docs/circular-progress -- 1.8 kB -- -1 B
/api-docs/click-away-listener -- 1.13 kB -- -1 B
/api-docs/collapse -- 1.76 kB -- -1 B
/api-docs/container -- 1.62 kB -- -1 B
/api-docs/css-baseline -- 1.14 kB -- -1 B
/api-docs/dialog-actions -- 1.22 kB -- -1 B
/api-docs/dialog-content-text -- 1.23 kB -- -1 B
/api-docs/dialog-content -- 1.2 kB -- -1 B
/api-docs/dialog-title -- 1.26 kB -- -1 B
/api-docs/dialog -- 2.48 kB -- -1 B
/api-docs/divider -- 1.55 kB -- -1 B
/api-docs/drawer -- 1.87 kB -- -1 B
/api-docs/expansion-panel-actions -- 1.25 kB -- -1 B
/api-docs/expansion-panel-details -- 1.18 kB -- -1 B
/api-docs/expansion-panel-summary -- 1.46 kB -- -1 B
/api-docs/expansion-panel -- 1.7 kB -- -1 B
/api-docs/fab -- 1.86 kB -- -1 B
/api-docs/fade -- 1.17 kB -- -1 B
/api-docs/filled-input -- 2.65 kB -- -1 B
/api-docs/form-control-label -- 1.73 kB -- -1 B
/api-docs/form-control -- 2.1 kB -- -1 B
/api-docs/form-group -- 1.3 kB -- -1 B
/api-docs/form-helper-text -- 1.66 kB -- -1 B
/api-docs/form-label -- 1.59 kB -- -1 B
/api-docs/grid-list-tile-bar -- 1.54 kB -- -1 B
/api-docs/grid-list-tile -- 1.46 kB -- -1 B
/api-docs/grid-list -- 1.37 kB -- -1 B
/api-docs/grid -- 2.29 kB -- -1 B
/api-docs/grow -- 1.23 kB -- -1 B
/api-docs/hidden -- 1.32 kB -- -1 B
/api-docs/icon-button -- 1.85 kB -- -1 B
/api-docs/icon -- 1.54 kB -- -1 B
/api-docs/input-adornment -- 1.68 kB -- -1 B
/api-docs/input-base -- 2.74 kB -- -1 B
/api-docs/input -- 2.61 kB -- -1 B
/api-docs/linear-progress -- 1.78 kB -- -1 B
/api-docs/link -- 1.68 kB -- -1 B
/api-docs/list-item-avatar -- 1.25 kB -- -1 B
/api-docs/list-item-icon -- 1.27 kB -- -1 B
/api-docs/list-item-secondary-action -- 1.22 kB -- -1 B
/api-docs/list-item-text -- 1.54 kB -- -1 B
/api-docs/list-item -- 2 kB -- -1 B
/api-docs/list-subheader -- 1.51 kB -- -1 B
/api-docs/list -- 1.44 kB -- -1 B
/api-docs/menu-item -- 1.46 kB -- -1 B
/api-docs/menu-list -- 1.33 kB -- -1 B
/api-docs/mobile-stepper -- 1.67 kB -- -1 B
/api-docs/modal -- 2.14 kB -- -1 B
/api-docs/native-select -- 1.83 kB -- -1 B
/api-docs/no-ssr -- 1.09 kB -- -1 B
/api-docs/outlined-input -- 2.76 kB -- -1 B
/api-docs/pagination-item -- 1.71 kB -- -1 B
/api-docs/pagination -- 1.98 kB -- -1 B
/api-docs/paper -- 1.61 kB -- -1 B
/api-docs/popover -- 2.5 kB -- -1 B
/api-docs/popper -- 1.76 kB -- -1 B
/api-docs/portal -- 1.12 kB -- -1 B
/api-docs/radio-group -- 1.2 kB -- -1 B
/api-docs/radio -- 1.89 kB -- -1 B
/api-docs/rating -- 2.25 kB -- -1 B
/api-docs/root-ref -- 1.2 kB -- -1 B
/api-docs/scoped-css-baseline -- 1.15 kB -- -1 B
/api-docs/select -- 2.65 kB -- -1 B
/api-docs/skeleton -- 1.52 kB -- -1 B
/api-docs/slide -- 1.31 kB -- -1 B
/api-docs/slider -- 2.85 kB -- -1 B
/api-docs/snackbar-content -- 1.36 kB -- -1 B
/api-docs/snackbar -- 2.46 kB -- -1 B
/api-docs/speed-dial-action -- 1.67 kB -- -1 B
/api-docs/speed-dial-icon -- 1.29 kB -- -1 B
/api-docs/speed-dial -- 2.05 kB -- -1 B
/api-docs/step-button -- 1.38 kB -- -1 B
/api-docs/step-connector -- 1.29 kB -- -1 B
/api-docs/step-content -- 1.47 kB -- -1 B
/api-docs/step-icon -- 1.33 kB -- -1 B
/api-docs/step-label -- 1.64 kB -- -1 B
/api-docs/step -- 1.38 kB -- -1 B
/api-docs/stepper -- 1.6 kB -- -1 B
/api-docs/swipeable-drawer -- 1.78 kB -- -1 B
/api-docs/switch -- 2.22 kB -- -1 B
/api-docs/tab -- 1.74 kB -- -1 B
/api-docs/table-body -- 1.21 kB -- -1 B
/api-docs/table-cell -- 1.87 kB -- -1 B
/api-docs/table-container -- 1.22 kB -- -1 B
/api-docs/table-footer -- 1.22 kB -- -1 B
/api-docs/table-head -- 1.21 kB -- -1 B
/api-docs/table-pagination -- 2.21 kB -- -1 B
/api-docs/table-row -- 1.43 kB -- -1 B
/api-docs/table-sort-label -- 1.57 kB -- -1 B
/api-docs/table -- 1.43 kB -- -1 B
/api-docs/tabs -- 2.28 kB -- -1 B
/api-docs/text-field -- 2.94 kB -- -1 B
/api-docs/textarea-autosize -- 908 B -- -1 B
/api-docs/toggle-button-group -- 1.56 kB -- -1 B
/api-docs/toggle-button -- 1.55 kB -- -1 B
/api-docs/toolbar -- 1.4 kB -- -1 B
/api-docs/tooltip -- 2.3 kB -- -1 B
/api-docs/tree-item -- 1.53 kB -- -1 B
/api-docs/typography -- 2.33 kB -- -1 B
/api-docs/zoom -- 1.19 kB -- -1 B
/blog/2019-developer-survey-results -- 5.97 kB -- -1 B
/blog/2019 -- 3.86 kB -- -1 B
/blog/april-2019-update -- 2.75 kB -- -1 B
/blog/august-2019-update -- 1.86 kB -- -1 B
/blog/december-2019-update -- 2 kB -- -1 B
/blog/july-2019-update -- 1.75 kB -- -1 B
/blog/june-2019-update -- 1.62 kB -- -1 B
/blog/march-2019-update -- 2.15 kB -- -1 B
/blog/material-ui-v1-is-out -- 6.28 kB -- -1 B
/blog/material-ui-v4-is-out -- 9.31 kB -- -1 B
/blog/may-2019-update -- 1.95 kB -- -1 B
/blog/november-2019-update -- 2.36 kB -- -1 B
/blog/october-2019-update -- 2.1 kB -- -1 B
/blog/september-2019-update -- 2.29 kB -- -1 B
/company/about -- 1.56 kB -- -1 B
/company/contact -- 1.14 kB -- -1 B
/company/jobs -- 1.15 kB -- -1 B
/company/software-engineer -- 5.07 kB -- -1 B
/components/about-the-lab -- 5.55 kB -- -1 B
/components/alert -- 12.5 kB -- -1 B
/components/app-bar -- 30.9 kB -- -1 B
/components/avatars -- 8.53 kB -- -1 B
/components/backdrop -- 3.2 kB -- -1 B
/components/badges -- 15.1 kB -- -1 B
/components/bottom-navigation -- 6.22 kB -- -1 B
/components/box -- 7.96 kB -- -1 B
/components/breadcrumbs -- 14.3 kB -- -1 B
/components/button-group -- 6.66 kB -- -1 B
/components/buttons -- 24.3 kB -- -1 B
/components/cards -- 16.9 kB -- -1 B
/components/checkboxes -- 16.6 kB -- -1 B
/components/chips -- 21.5 kB -- -1 B
/components/click-away-listener -- 3.38 kB -- -1 B
/components/container -- 3.84 kB -- -1 B
/components/css-baseline -- 5.96 kB -- -1 B
/components/dialogs -- 42.1 kB -- -1 B
/components/dividers -- 12.3 kB -- -1 B
/components/drawers -- 29.3 kB -- -1 B
/components/expansion-panels -- 20.1 kB -- -1 B
/components/floating-action-button -- 10.2 kB -- -1 B
/components/grid -- 33.9 kB -- -1 B
/components/hidden -- 10.5 kB -- -1 B
/components/icons -- 22.8 kB -- -1 B
/components/links -- 6.82 kB -- -1 B
/components/lists -- 33 kB -- -1 B
/components/material-icons -- 728 kB -- -1 B
/components/menus -- 23.2 kB -- -1 B
/components/modal -- 11.5 kB -- -1 B
/components/no-ssr -- 5.02 kB -- -1 B
/components/paper -- 3.33 kB -- -1 B
/components/pickers -- 38.2 kB -- -1 B
/components/popover -- 14.7 kB -- -1 B
/components/popper -- 22.5 kB -- -1 B
/components/portal -- 3.29 kB -- -1 B
/components/progress -- 21.7 kB -- -1 B
/components/radio-buttons -- 15.2 kB -- -1 B
/components/rating -- 10.7 kB -- -1 B
/components/selects -- 28.8 kB -- -1 B
/components/skeleton -- 10.1 kB -- -1 B
/components/slider -- 14.6 kB -- -1 B
/components/snackbars -- 24.8 kB -- -1 B
/components/speed-dial -- 14.6 kB -- -1 B
/components/steppers -- 35.9 kB -- -1 B
/components/switches -- 16 kB -- -1 B
/components/tables -- 177 kB -- -1 B
/components/tabs -- 19.2 kB -- -1 B
/components/text-fields -- 54.7 kB -- -1 B
/components/textarea-autosize -- 2.81 kB -- -1 B
/components/toggle-button -- 10.6 kB -- -1 B
/components/tooltips -- 17.3 kB -- -1 B
/components/transfer-list -- 9.28 kB -- -1 B
/components/transitions -- 10.8 kB -- -1 B
/components/tree-view -- 11.2 kB -- -1 B
/components/typography -- 9.7 kB -- -1 B
/components/use-media-query -- 13.1 kB -- -1 B
/customization/breakpoints -- 15.7 kB -- -1 B
/customization/color -- 21.6 kB -- -1 B
/customization/components -- 37.4 kB -- -1 B
/customization/default-theme -- 8 kB -- -1 B
/customization/density -- 9.15 kB -- -1 B
/customization/globals -- 4.65 kB -- -1 B
/customization/palette -- 11.9 kB -- -1 B
/customization/spacing -- 2.49 kB -- -1 B
/customization/theming -- 17.1 kB -- -1 B
/customization/typography -- 11.6 kB -- -1 B
/customization/z-index -- 3.05 kB -- -1 B
/discover-more/backers -- 2.89 kB -- -1 B
/discover-more/changelog -- 1.37 kB -- -1 B
/discover-more/languages -- 3.32 kB -- -1 B
/discover-more/related-projects -- 6.72 kB -- -1 B
/discover-more/roadmap -- 3.67 kB -- -1 B
/discover-more/showcase -- 13.3 kB -- -1 B
/discover-more/team -- 6.51 kB -- -1 B
/discover-more/vision -- 7.03 kB -- -1 B
/getting-started/example-projects -- 6.08 kB -- -1 B
/getting-started/faq -- 31.8 kB -- -1 B
/getting-started/installation -- 7.6 kB -- -1 B
/getting-started/learn -- 8.39 kB -- -1 B
/getting-started/support -- 7.83 kB -- -1 B
/getting-started/supported-components -- 6.19 kB -- -1 B
/getting-started/supported-platforms -- 5.69 kB -- -1 B
/getting-started/templates -- 8.3 kB -- -1 B
/getting-started/templates/album -- 5.65 kB -- -1 B
/getting-started/templates/blog -- 7.44 kB -- -1 B
/getting-started/templates/checkout -- 11.2 kB -- -1 B
/getting-started/templates/dashboard -- 8.55 kB -- -1 B
/getting-started/templates/pricing -- 7.86 kB -- -1 B
/getting-started/templates/sign-in-side -- 9.31 kB -- -1 B
/getting-started/templates/sign-in -- 9.54 kB -- -1 B
/getting-started/templates/sign-up -- 9.65 kB -- -1 B
/getting-started/templates/sticky-footer -- 1.54 kB -- -1 B
/getting-started/usage -- 9.37 kB -- -1 B
/guides/api -- 17.4 kB -- -1 B
/guides/composition -- 14 kB -- -1 B
/guides/flow -- 2.21 kB -- -1 B
/guides/interoperability -- 14.9 kB -- -1 B
/guides/migration-v0x -- 7.23 kB -- -1 B
/guides/migration-v3 -- 22.3 kB -- -1 B
/guides/minimizing-bundle-size -- 6.74 kB -- -1 B
/guides/responsive-ui -- 4.18 kB -- -1 B
/guides/right-to-left -- 6.7 kB -- -1 B
/guides/server-rendering -- 8.38 kB -- -1 B
/guides/testing -- 8.33 kB -- -1 B
/guides/typescript -- 13.4 kB -- -1 B
/performance/table-component -- 1.44 kB -- -1 B
/performance/table-emotion -- 2.97 kB -- -1 B
/performance/table-hook -- 2.23 kB -- -1 B
/performance/table-mui -- 4.42 kB -- -1 B
/performance/table-raw -- 613 B -- -1 B
/performance/table-styled-components -- 2.61 kB -- -1 B
/premium-themes/onepirate -- 7.11 kB -- -1 B
/premium-themes/onepirate/forgot-password -- 1.01 kB -- -1 B
/premium-themes/onepirate/privacy -- 4.44 kB -- -1 B
/premium-themes/onepirate/sign-in -- 1.07 kB -- -1 B
/premium-themes/onepirate/sign-up -- 1.12 kB -- -1 B
/premium-themes/onepirate/terms -- 11.8 kB -- -1 B
/premium-themes/paperbase -- 8.72 kB -- -1 B
/styles/advanced -- 30.2 kB -- -1 B
/styles/api -- 16 kB -- -1 B
/styles/basics -- 17.6 kB -- -1 B
/system/api -- 5.85 kB -- -1 B
/system/basics -- 25.2 kB -- -1 B
/system/borders -- 4.04 kB -- -1 B
/system/display -- 6.51 kB -- -1 B
/system/flexbox -- 5.72 kB -- -1 B
/system/palette -- 4.29 kB -- -1 B
/system/positions -- 2.46 kB -- -1 B
/system/shadows -- 3.44 kB -- -1 B
/system/sizing -- 3.44 kB -- -1 B
/system/spacing -- 5.97 kB -- -1 B
/system/typography -- 4.22 kB -- -1 B
/versions -- 23.1 kB -- -1 B
docs:chunk:shared -- 68.4 kB -- -1 B
docs:shared:chunk/commons -- 5.99 kB -- -1 B
docs:shared:chunk/framework -- 42.3 kB -- -1 B
docs:shared:runtime/main -- 6.78 kB -- -1 B
docs:shared:runtime/webpack -- 1.24 kB -- -1 B
bundle Size Change Size Gzip Change Gzip
@material-ui/lab ▲ +287 B (+0.14% ) 202 kB ▲ +115 B (+0.19% ) 60 kB
Autocomplete ▲ +287 B (+0.21% ) 136 kB ▲ +109 B (+0.26% ) 42.6 kB
@material-ui/core -- 361 kB -- 99.3 kB
@material-ui/core[umd] -- 319 kB -- 92.6 kB
@material-ui/styles -- 52 kB -- 15.6 kB
@material-ui/system -- 17.2 kB -- 4.52 kB
Alert -- 87.3 kB -- 27.6 kB
AlertTitle -- 68.2 kB -- 21.4 kB
AppBar -- 68.1 kB -- 21.3 kB
Avatar -- 69.2 kB -- 21.6 kB
AvatarGroup -- 70.2 kB -- 22.2 kB
Backdrop -- 71.9 kB -- 22.2 kB
Badge -- 69.4 kB -- 21.5 kB
BottomNavigation -- 66.5 kB -- 20.8 kB
BottomNavigationAction -- 79.5 kB -- 25.1 kB
Box -- 73 kB -- 22.1 kB
Breadcrumbs -- 84.4 kB -- 26.7 kB
Button -- 83.7 kB -- 25.7 kB
ButtonBase -- 78 kB -- 24.4 kB
ButtonGroup -- 87.2 kB -- 26.9 kB
Card -- 66.9 kB -- 20.9 kB
CardActionArea -- 79.1 kB -- 25 kB
CardActions -- 66.1 kB -- 20.7 kB
CardContent -- 66 kB -- 20.6 kB
CardHeader -- 69.1 kB -- 21.7 kB
CardMedia -- 66.4 kB -- 20.8 kB
Checkbox -- 86.1 kB -- 27.2 kB
Chip -- 86.6 kB -- 26.6 kB
CircularProgress -- 68.2 kB -- 21.4 kB
ClickAwayListener -- 3.84 kB -- 1.54 kB
Collapse -- 72.1 kB -- 22.3 kB
colorManipulator -- 3.88 kB -- 1.52 kB
Container -- 67.2 kB -- 21 kB
CssBaseline -- 66 kB -- 20.7 kB
Dialog -- 86.9 kB -- 27.2 kB
DialogActions -- 66.2 kB -- 20.7 kB
DialogContent -- 66.3 kB -- 20.7 kB
DialogContentText -- 68.1 kB -- 21.3 kB
DialogTitle -- 68.3 kB -- 21.4 kB
Divider -- 66.8 kB -- 20.9 kB
docs:/ -- 10.7 kB -- -1 B
docs:/_app -- 34.3 kB -- -1 B
Drawer -- 88.6 kB -- 27 kB
ExpansionPanel -- 75.6 kB -- 23.7 kB
ExpansionPanelActions -- 66.1 kB -- 20.7 kB
ExpansionPanelDetails -- 66 kB -- 20.6 kB
ExpansionPanelSummary -- 82.1 kB -- 26 kB
Fab -- 80.8 kB -- 25.1 kB
Fade -- 27.8 kB -- 9.23 kB
FilledInput -- 77.6 kB -- 24.1 kB
FormControl -- 68.4 kB -- 21.3 kB
FormControlLabel -- 69.5 kB -- 21.8 kB
FormGroup -- 66.1 kB -- 20.5 kB
FormHelperText -- 67.4 kB -- 20.9 kB
FormLabel -- 67.5 kB -- 20.9 kB
Grid -- 69.2 kB -- 21.7 kB
GridList -- 66.5 kB -- 20.8 kB
GridListTile -- 67.8 kB -- 21.2 kB
GridListTileBar -- 67.3 kB -- 21 kB
Grow -- 28.4 kB -- 9.44 kB
Hidden -- 70 kB -- 22 kB
Icon -- 66.9 kB -- 20.9 kB
IconButton -- 80.1 kB -- 25 kB
Input -- 76.6 kB -- 23.9 kB
InputAdornment -- 69.1 kB -- 21.8 kB
InputBase -- 74.7 kB -- 23.4 kB
InputLabel -- 69.3 kB -- 21.4 kB
LinearProgress -- 69.4 kB -- 21.4 kB
Link -- 70.6 kB -- 22.3 kB
List -- 66.4 kB -- 20.7 kB
ListItem -- 81 kB -- 25.3 kB
ListItemAvatar -- 66.2 kB -- 20.7 kB
ListItemIcon -- 66.2 kB -- 20.7 kB
ListItemSecondaryAction -- 66.1 kB -- 20.6 kB
ListItemText -- 69 kB -- 21.7 kB
ListSubheader -- 66.8 kB -- 21 kB
Menu -- 92.5 kB -- 28.5 kB
MenuItem -- 82.1 kB -- 25.7 kB
MenuList -- 70 kB -- 21.9 kB
MobileStepper -- 71.9 kB -- 22.5 kB
Modal -- 14.9 kB -- 5.23 kB
NativeSelect -- 80.8 kB -- 25.6 kB
NoSsr -- 2.18 kB -- 1.03 kB
OutlinedInput -- 78.6 kB -- 24.5 kB
Pagination -- 88.3 kB -- 27.2 kB
PaginationItem -- 84.7 kB -- 26.1 kB
Paper -- 66.4 kB -- 20.7 kB
Popover -- 87 kB -- 26.9 kB
Popper -- 28.8 kB -- 10.3 kB
Portal -- 2.87 kB -- 1.29 kB
Radio -- 87.1 kB -- 27.5 kB
RadioGroup -- 67.8 kB -- 21.1 kB
Rating -- 74.5 kB -- 23.9 kB
RootRef -- 4.61 kB -- 1.77 kB
ScopedCssBaseline -- 66.9 kB -- 20.9 kB
Select -- 119 kB -- 35.6 kB
Skeleton -- 67.1 kB -- 21.1 kB
Slide -- 29.8 kB -- 9.84 kB
Slider -- 79.8 kB -- 25.4 kB
Snackbar -- 79.3 kB -- 24.8 kB
SnackbarContent -- 67.6 kB -- 21 kB
SpeedDial -- 90.2 kB -- 28.5 kB
SpeedDialAction -- 121 kB -- 38.6 kB
SpeedDialIcon -- 68.6 kB -- 21.5 kB
Step -- 66.7 kB -- 20.9 kB
StepButton -- 86.3 kB -- 27.2 kB
StepConnector -- 66.8 kB -- 21 kB
StepContent -- 73.2 kB -- 22.8 kB
StepIcon -- 68.6 kB -- 21.4 kB
StepLabel -- 72.6 kB -- 22.5 kB
Stepper -- 68.9 kB -- 21.7 kB
styles/createMuiTheme -- 21.6 kB -- 7.46 kB
SvgIcon -- 67.1 kB -- 20.9 kB
SwipeableDrawer -- 96 kB -- 30.1 kB
Switch -- 85.3 kB -- 26.8 kB
Tab -- 80.3 kB -- 25.5 kB
Table -- 66.6 kB -- 20.9 kB
TableBody -- 66.2 kB -- 20.7 kB
TableCell -- 68.1 kB -- 21.4 kB
TableContainer -- 66 kB -- 20.6 kB
TableFooter -- 66.2 kB -- 20.7 kB
TableHead -- 66.2 kB -- 20.7 kB
TablePagination -- 146 kB -- 42.9 kB
TableRow -- 66.5 kB -- 20.8 kB
TableSortLabel -- 81.4 kB -- 25.7 kB
Tabs -- 89.3 kB -- 28.5 kB
TextareaAutosize -- 5.19 kB -- 2.17 kB
TextField -- 128 kB -- 37.6 kB
ToggleButton -- 80.1 kB -- 25.4 kB
ToggleButtonGroup -- 67.3 kB -- 21.1 kB
Toolbar -- 66.4 kB -- 20.8 kB
Tooltip -- 105 kB -- 33.3 kB
TreeItem -- 79.2 kB -- 25.1 kB
TreeView -- 72.2 kB -- 22.7 kB
Typography -- 67.7 kB -- 21.1 kB
useAutocomplete -- 15.7 kB -- 5.61 kB
useMediaQuery -- 2.56 kB -- 1.06 kB
Zoom -- 27.8 kB -- 9.35 kB

Generated by 🚫 dangerJS against fee1583

@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Mar 21, 2020
oliviertassinari
oliviertassinari reviewed Mar 21, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start

packages/material-ui-lab/src/Autocomplete/Autocomplete.d.ts Outdated Show resolved Hide resolved
packages/material-ui-lab/src/Autocomplete/Autocomplete.d.ts Outdated Show resolved Hide resolved
packages/material-ui-lab/src/Autocomplete/Autocomplete.js Outdated Show resolved Hide resolved
packages/material-ui-lab/src/Autocomplete/Autocomplete.js Outdated Show resolved Hide resolved
docs/src/pages/components/autocomplete/Tags.js Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari added new feature New feature or request PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Mar 21, 2020
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 22, 2020
@netochaves netochaves force-pushed the feat/autocomplete-filterMax-prop branch 2 times, most recently from ebdf4b4 to a618f46 Compare March 22, 2020 18:38
@netochaves netochaves changed the title [Autocomplete] Add filterMax prop [Autocomplete] Add filterMaxTags prop Mar 22, 2020
@netochaves netochaves force-pushed the feat/autocomplete-filterMax-prop branch 5 times, most recently from f29cd03 to a0aa08d Compare March 22, 2020 20:11
@oliviertassinari oliviertassinari changed the title [Autocomplete] Add filterMaxTags prop [Autocomplete] Add limitTags prop Mar 22, 2020
@oliviertassinari oliviertassinari removed PR: out-of-date The pull request has merge conflicts and can't be merged PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Mar 22, 2020
@oliviertassinari oliviertassinari force-pushed the feat/autocomplete-filterMax-prop branch 5 times, most recently from 4c6e446 to 5d16990 Compare March 22, 2020 21:06
oliviertassinari
oliviertassinari approved these changes Mar 22, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@netochaves I have applied the following

  • I have rebased on master to solve the conflict
  • I have removed "more" from the built-in message to avoid any translation concerns
  • I have applied the tag class name to the limit label to ensure proper spacing
  • I have added a function to customize the limit label
  • I have renamed the props to be shorter and more descriptive
  • I have simplified the test case

If you could double check the changes, it would be awesome. feedback welcome

@oliviertassinari oliviertassinari force-pushed the feat/autocomplete-filterMax-prop branch from 5d16990 to fb87c9b Compare March 22, 2020 21:10
@oliviertassinari oliviertassinari force-pushed the feat/autocomplete-filterMax-prop branch from fb87c9b to fee1583 Compare March 22, 2020 21:19
@netochaves
Copy link
Contributor Author

Thanks for these improvements @oliviertassinari. I had some troubles with prettier because of this commit #20211, sorry about that.

I really liked the getLimitTagsText prop. Well done.

@oliviertassinari oliviertassinari merged commit 3a64fe1 into mui:master Mar 23, 2020
@oliviertassinari
Copy link
Member

Great, let's move forward :)

@xajis
Copy link

xajis commented Mar 27, 2020

Thanks for the improvement! I would like to use this but when i install the npm package it seems to be missing.. Am i doing something wrong? Do i need to wait for some time?

EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Mar 30, 2020
@netochaves @EsoterikStare
[Autocomplete] Add limitTags prop (mui#20209)
2eff7a9
@vlafiser
Copy link

Yes, I also don't see it in the latest package available on NPM.

@oliviertassinari
Copy link
Member

It's live https://unpkg.com/browse/@material-ui/[email protected]/Autocomplete/Autocomplete.js.

This was referenced Mar 30, 2020
Merged
Closed
Merged
Merged
Merged
Merged
This was referenced Apr 7, 2020
Merged
Merged
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 27, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Autocomplete] Multiple with many options take too much space
5 participants
@netochaves @mui-pr-bot @oliviertassinari @xajis @vlafiser