[test] Migrate CircularProgress and Collapse to testing-library #20789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: beabed8...fffc9e7 Details of page changes
|
|
The linter gives problem with tree item 😕 +++ b/packages/material-ui-lab/src/TreeItem/TreeItem.test.js
@@ -735,6 +735,36 @@ describe('<TreeItem />', () => {
fireEvent.keyDown(document.activeElement, { key: 'v', shiftKey: true });
expect(getByTestId('apple')).toHaveFocus();
});
+
+ it('should not throw when an item is removed', () => {
+ function TestComponent() {
+ const [hide, setState] = React.useState(false);
+ return (
+ <React.Fragment>
+ <button type="button" onClick={() => setState(true)}>
+ Hide
+ </button>
+ <TreeView>
+ {!hide && <TreeItem nodeId="hide" label="ab" />}
+ <TreeItem nodeId="keyDown" data-testid="keyDown" />
+ <TreeItem nodeId="navTo" data-testid="navTo" label="ac" />
+ </TreeView>
+ </React.Fragment>
+ );
+ }
+
+ const { getByText, getByTestId } = render(<TestComponent />);
+ fireEvent.click(getByText('Hide'));
+ const navTreeItem = getByTestId('navTo');
+ expect(navTreeItem).not.to.have.focus;
+
+ expect(() => {
+ fireEvent.keyDown(getByTestId('keyDown'), { key: 'a' });
+ }).not.to.throw();
+
+ expect(navTreeItem).to.have.focus;
+ expect(navTreeItem).to.have.attribute('tabindex', '0');
+ });
});
The line where where he check's the focus must call the function not.to.have.focus() to.have.focus() |
This branch seems outdated. We now lint against |
|
Yes i know for the branch |
eps1lon
reviewed
Apr 27, 2020
|
@eps1lon Do you know why with testing-library fake timer dons't work well? |
|
Could you push the code so that I can take a look? |
|
Yes of course |
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
fix/crcular_collapse_migrate_testing_library
branch
from
f109f50 to
fffc9e7
Compare
|
@marcosvega91 The key difference between the previous test and your new one is around how the cleanup logic is run. Both unmounts the component |
oliviertassinari
removed
the
PR: out-of-date
oliviertassinari
changed the title
oliviertassinari
approved these changes
May 4, 2020
|
You are totally right @oliviertassinari |
eps1lon
approved these changes
May 4, 2020
|
@marcosvega91 Very nice, thanks! |
|
I'm not good like you @eps1lon @oliviertassinari 😭 |
Not at all. That's totally normal that PRs don't work on the first push. This is what review is for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eps1lon @oliviertassinari for the collapse component there is the problem with react strict.
How we can do? The problem is the Transition component