Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Bump next to 9.5.0 #21975

Merged
merged 5 commits into from
Jul 29, 2020
Merged

[docs] Bump next to 9.5.0 #21975

merged 5 commits into from
Jul 29, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jul 28, 2020 •
edited
Loading

Going through changes individually to observe bundle implications.

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Jul 28, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 28, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 7e4e2d7

@eps1lon eps1lon marked this pull request as draft July 28, 2020 09:11
eps1lon
eps1lon commented Jul 28, 2020
View reviewed changes
docs/package.json Outdated
@@ -61,6 +61,7 @@
"clsx": "^1.0.4",
"core-js": "^2.6.11",
"cross-env": "^7.0.0",
"cross-fetch": "^3.0.5",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used in docs/scripts

@eps1lon eps1lon marked this pull request as ready for review July 28, 2020 14:34
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 28, 2020 •
edited
Loading

Should we use the new trailingSlash: true option to match the export behavior? https://nextjs.org/docs/api-reference/next.config.js/trailing-slash. I don't know the relation between the trailingSlash and exportTrailingSlash. This could help avoir 301 when writing the document, copying the URL in dev mode that are different in production.

@eps1lon
Copy link
Member Author

eps1lon commented Jul 28, 2020 •
edited by oliviertassinari
Loading

I don't know the relation between the trailingSlash and exportTrailingSlash

Me neither which is why I didn't use it. I'd rather not use an under-documented feature than use it wrong.

@oliviertassinari
Copy link
Member

I have asked for clarification on vercel/next.js#15598. What do you mean by "under-documented"? Do you see something else missing we should report?

@eps1lon
Copy link
Member Author

eps1lon commented Jul 29, 2020

"under-documented" = not documented enough

@eps1lon eps1lon requested a review from oliviertassinari July 29, 2020 04:34
@eps1lon
Copy link
Member Author

eps1lon commented Jul 29, 2020

@oliviertassinari Any other points? Can always look at the trailing slash later, no?

@eps1lon eps1lon merged commit 83c0bee into mui:next Jul 29, 2020
@eps1lon eps1lon deleted the docs/next-9.5 branch July 29, 2020 06:06
@eps1lon eps1lon added the dependencies Update of dependencies label Jul 29, 2020
@oliviertassinari oliviertassinari mentioned this pull request Jul 31, 2020
Merged
@eps1lon eps1lon mentioned this pull request Sep 8, 2020
Closed
@oliviertassinari oliviertassinari mentioned this pull request Dec 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
dependencies Update of dependencies docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari