Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pagination] Rename round -> circular for consistency #22009

Merged
merged 3 commits into from
Aug 1, 2020
Merged

[Pagination] Rename round -> circular for consistency #22009

merged 3 commits into from
Aug 1, 2020

Conversation

kodai3
Copy link
Contributor

@kodai3 kodai3 commented Aug 1, 2020 •
edited by oliviertassinari
Loading

Breaking changes

Pagination

  • Rename round to circular for consistency. The possible values should be adjectives, not nouns:

    -<Pagination shape="round">
+<Pagination shape="circular">

PaginationItem

  • Rename round to circular for consistency. The possible values should be adjectives, not nouns:

    -<PaginationItem shape="round">
+<PaginationItem shape="circular">

One item of #21964

I changed two components on 1PR,because Pagination depend on PaginationItem by function renderItem

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 1, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 60c13c9

@eps1lon eps1lon added breaking change component: pagination This is the name of the generic UI component, not the React module! labels Aug 1, 2020
@oliviertassinari oliviertassinari changed the title [Pagination] rename round -> circular for consistency [Pagination] Rename round -> circular for consistency Aug 1, 2020
@oliviertassinari oliviertassinari merged commit ceffdd9 into mui:next Aug 1, 2020
@oliviertassinari
Copy link
Member

@kodai3 Well done

@kodai3 kodai3 deleted the update/rename-pagination-shape-consistency branch August 2, 2020 22:08
@eps1lon eps1lon added this to the v5 milestone Sep 15, 2020
@oliviertassinari oliviertassinari mentioned this pull request Sep 15, 2020
Closed
42 tasks
@mbrookes mbrookes mentioned this pull request Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
breaking change component: pagination This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
v5-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@kodai3 @mui-pr-bot @oliviertassinari @eps1lon