Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Don't fire onChange if current value #22381

Merged
merged 4 commits into from
Aug 28, 2020
Merged

[Tabs] Don't fire onChange if current value #22381

merged 4 commits into from
Aug 28, 2020

Conversation

jjoselv
Copy link
Contributor

@jjoselv jjoselv commented Aug 27, 2020 •
edited by oliviertassinari
Loading

[x] I have followed (at least) the PR section of the contributing guide.

Closes #22378

@jjoselv jjoselv mentioned this pull request Aug 27, 2020
Closed
2 tasks
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 27, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 949867e

eps1lon
eps1lon previously requested changes Aug 27, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can simplify the test a bit

packages/material-ui/src/Tabs/Tabs.test.js Outdated Show resolved Hide resolved
@jjoselv jjoselv requested a review from eps1lon August 27, 2020 15:33
@oliviertassinari oliviertassinari changed the title fix: prevent trigger onChange when value did not change [Tabs] Don't fire onChange if current value Aug 27, 2020
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module! labels Aug 27, 2020
@jjoselv jjoselv requested a review from eps1lon August 27, 2020 17:56
@oliviertassinari oliviertassinari merged commit a43ac9f into mui:next Aug 28, 2020
@oliviertassinari
Copy link
Member

@jjoselv Thanks!

@jjoselv
Copy link
Contributor Author

jjoselv commented Aug 28, 2020

Anytime! 😊

@jjoselv jjoselv deleted the fix-on-change-fire-even-if-value-did-not-change branch August 28, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tabs] onChange fire even if value didn't change
4 participants
@jjoselv @mui-pr-bot @oliviertassinari @eps1lon